Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: System messages styling #14189

Merged
merged 5 commits into from
Apr 22, 2019
Merged

Regression: System messages styling #14189

merged 5 commits into from
Apr 22, 2019

Conversation

tassoevan
Copy link
Contributor

This PR removes .collapsed class from system messages and it modifies the .system class itself.

Bugs addressed:

  • grouping should ignore system messages
  • inline-flex display in the message body is ignoring spaces around span elements
  • attachments are hidden

@tassoevan tassoevan added this to the 1.0.0 milestone Apr 18, 2019
@tassoevan tassoevan requested review from rodrigok and ggazzo April 18, 2019 19:09
@ggazzo ggazzo merged commit 9d211f3 into develop Apr 22, 2019
@ggazzo ggazzo deleted the fix/system-messages branch April 22, 2019 21:45
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees
No one assigned
Labels
feat: message type: regression ui/ux
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tassoevan @ggazzo