Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New eslint rules #14332

Merged
merged 13 commits into from
May 10, 2019
Merged

New eslint rules #14332

merged 13 commits into from
May 10, 2019

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Apr 30, 2019

New rules are not yet in this PR, I'll release it before merging.

The rules are being implemented by RocketChat/eslint-config-rocketchat#8

I recommend reviewing by commit.

@d-gubert
Copy link
Member

d-gubert commented May 2, 2019

Tests passing are a good sign! :D

@sampaiodiego
Copy link
Member Author

yep! :D

what is scary is that the new code (following the new rules) is still valid for current rules 😝

@tassoevan
Copy link
Contributor

Im.kinda()
? annoyed
: by(this)

@d-gubert
Copy link
Member

d-gubert commented May 7, 2019

Im.kinda()
? annoyed
: by(this)

No indentation? 👀

I.would()
    ? beOk()
    : with(this).though()

What about you @tassoevan

@sampaiodiego sampaiodiego marked this pull request as ready for review May 10, 2019 14:18
@sampaiodiego sampaiodiego merged commit d53e264 into develop May 10, 2019
@sampaiodiego sampaiodiego deleted the new-eslint-rules branch May 10, 2019 15:03
@sampaiodiego sampaiodiego mentioned this pull request May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants