Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Downloading files when running in sub directory #14485

Merged
merged 12 commits into from
May 20, 2019
Merged

[FIX] Downloading files when running in sub directory #14485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4e9811c
fix uploading file (#14472)
May 13, 2019
46c30f3
[FIX] fix file-upload (#14472)
May 13, 2019
3455ad1
solved
May 14, 2019
be8c49e
Merge branch 'develop' into develop-uploadfile
miolane May 15, 2019
1312b17
Merge branch 'develop' into develop-uploadfile
miolane May 16, 2019
22b7848
fix some other url bugs
May 16, 2019
19a1707
Merge branch 'develop' into develop-uploadfile
miolane May 16, 2019
ec47140
..
May 19, 2019
488ef42
Merge branch 'develop' into develop-uploadfile
tassoevan May 20, 2019
8b06374
Merge branch 'develop' into develop-uploadfile
tassoevan May 20, 2019
9f52d5b
Add more fixes to download URLs
tassoevan May 20, 2019
bd5f8c1
Fix merge conflict
tassoevan May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/message-attachments/client/messageAttachment.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@
{{#if title}}
<div class="attachment-title">
{{#if title_link}}
<a href="{{title_link}}" target="_blank" rel="noopener noreferrer">{{title}}</a>
<a href="{{getURL title_link}}" target="_blank" rel="noopener noreferrer">{{title}}</a>
{{#if title_link_download}}
<a class="attachment-download-icon rc-tooltip" aria-label="{{_ 'Download'}}" href="{{title_link}}" target="_blank" download="" rel="noopener noreferrer">{{> icon icon="download"}}</a>
<a class="attachment-download-icon rc-tooltip" aria-label="{{_ 'Download'}}" href="{{getURL title_link}}" target="_blank" download="" rel="noopener noreferrer">{{> icon icon="download"}}</a>
{{/if}}
{{else}}
{{title}}
Expand Down
2 changes: 1 addition & 1 deletion app/ui-flextab/client/tabs/uploadedFilesList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ Template.uploadedFilesList.events({
name: t('Download'),
action: () => {
const a = document.createElement('a');
a.href = this.file.url;
a.href = getURL(this.file.url);
a.download = this.file.name;
document.body.appendChild(a);
a.click();
Expand Down