Regression: thread loading parent msg if is not loaded #14839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekgonecrazy
approved these changes
Jun 20, 2019
sampaiodiego
pushed a commit
that referenced
this pull request
Jun 21, 2019
Merged
Kailash0311
pushed a commit
to WideChat/Rocket.Chat
that referenced
this pull request
Jun 29, 2019
* Service Account broadcast room callback added * Service Account Callback completed * CLI errors fixed * [NEW] Service Account one-tap login complete * Callbacks modified * Service Accounts directory tab added * [NEW] Service Accounts Login method * Typo fixed * CLI errors fixed * CLI errors fixed * [FIX] Anonymous chat read (RocketChat#14717) * Prevent errors when allowing anonymous read * getSingleMessage for anonymous users * Fix register user when allow read and write anonymous is enabled * Fix anonymous with sidebar extended as default Co-authored-by: ubergeekzone <ubergeekzone@gmail.com> * [New] Service Account directory feature * CLI errors fixed * UsernameExists meteor method fixed * Sync commit * [NEW] Add loading animation to webdav file picker (RocketChat#14759) * [NEW] Service Account subscription method added * [NEW] Service account subscription sidenav type * changed mongo version for snap from 3.2.7 to 3.4.20 (RocketChat#14838) * add _hidden for messages loaded by thread (RocketChat#14837) * Regression: thread loading parent msg if is not loaded (RocketChat#14839) * [IMPROVE] Layout of livechat manager pages to new style (RocketChat#13900) * [FIX] Removes E2E action button, icon and banner when E2E is disabled. (RocketChat#14810) * [IMPROVE] Adds link to download generated user data file (RocketChat#14175) * [FIX] Error when using Download My Data or Export My Data (RocketChat#14645) * [NEW] Custom User Status (RocketChat#13933) Co-Authored-By: Tasso Evangelista <tasso@tassoevan.me> Co-Authored-By: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-Authored-By: wreiske <wreiske@mieweb.com> * Allow debugging of cached collections by name (RocketChat#14859) * Regression: Allow debugging of cached collections by name (RocketChat#14862) * Regression: Fix desktop notifications not being sent (RocketChat#14860) * Broadcast Room name change handled * Lint errors fixed * getLoginToken method refactored * Console statements removed * Sidebar header permission modified * Merge branch service-accounts * Added service account directory search translation key * Subscribers count added * [NEW] Service Account sidenav type * Synced with base branch
Kailash0311
pushed a commit
to WideChat/Rocket.Chat
that referenced
this pull request
Jul 2, 2019
* [FIX] Load messages after disconnect and message box scroll missing (RocketChat#14668) * Removing unnecesary federation configs (RocketChat#14674) * [FIX] SAML login error. (RocketChat#14686) * Bump version to 1.1.1 * Service Account broadcast room callback added * Service Account Callback completed * CLI errors fixed * [NEW] Service Account one-tap login complete * Callbacks modified * Service Accounts directory tab added * [NEW] Service Accounts Login method * Typo fixed * CLI errors fixed * CLI errors fixed * [FIX] Anonymous chat read (RocketChat#14717) * Prevent errors when allowing anonymous read * getSingleMessage for anonymous users * Fix register user when allow read and write anonymous is enabled * Fix anonymous with sidebar extended as default Co-authored-by: ubergeekzone <ubergeekzone@gmail.com> * [FIX] User Real Name being erased when not modified (RocketChat#14711) * [FIX] User status information on User Info panel (RocketChat#14763) * [FIX] Anonymous chat read (RocketChat#14717) * Prevent errors when allowing anonymous read * getSingleMessage for anonymous users * Fix register user when allow read and write anonymous is enabled * Fix anonymous with sidebar extended as default Co-authored-by: ubergeekzone <ubergeekzone@gmail.com> * Bump version to 1.1.2 * [New] Service Account directory feature * CLI errors fixed * UsernameExists meteor method fixed * Sync commit * [NEW] Add loading animation to webdav file picker (RocketChat#14759) * [NEW] Service Account subscription method added * changed mongo version for snap from 3.2.7 to 3.4.20 (RocketChat#14838) * add _hidden for messages loaded by thread (RocketChat#14837) * Regression: thread loading parent msg if is not loaded (RocketChat#14839) * [IMPROVE] Layout of livechat manager pages to new style (RocketChat#13900) * [FIX] Removes E2E action button, icon and banner when E2E is disabled. (RocketChat#14810) * add _hidden for messages loaded by thread (RocketChat#14837) * Regression: thread loading parent msg if is not loaded (RocketChat#14839) * Bump version to 1.1.3 * [IMPROVE] Adds link to download generated user data file (RocketChat#14175) * [FIX] Error when using Download My Data or Export My Data (RocketChat#14645) * [NEW] Custom User Status (RocketChat#13933) Co-Authored-By: Tasso Evangelista <tasso@tassoevan.me> Co-Authored-By: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-Authored-By: wreiske <wreiske@mieweb.com> * Bump version to 1.2.0-rc.0 * Allow debugging of cached collections by name (RocketChat#14859) * Regression: Allow debugging of cached collections by name (RocketChat#14862) * Regression: Fix desktop notifications not being sent (RocketChat#14860) * Broadcast Room name change handled * Lint errors fixed * getLoginToken method refactored * Console statements removed * Sidebar header permission modified * Merge branch service-accounts * Added service account directory search translation key * Subscribers count added * [FIX] Custom status fixes (RocketChat#14853) * Fixes for status message text presence issues Added statusText to several api endpoints Changed statusMessage to statusText since that is what it is called everywhere * Fixed slash command for changing status * Fixed the "name is required" issue * Make sure the status is set blank if selecting a default status... we don't want an "online" status when someone is actually offline! * Fixes display of custom status on the room header * Changed the header of DM rooms to query the server for the user status text when it is not found on the internal collection * Changed Custom Status methods to check if the user is logged in * Improved code readability * Fix getting status list before logging in * Bump version to 1.2.0-rc.1 * [FIX] LinkedIn OAuth login (RocketChat#14887) * [NEW] Show App bundles and its apps (RocketChat#14886) * Bump version to 1.2.0-rc.2 * Bump version to 1.2.0 * Bump version to 1.3.0-develop * [FIX] Not showing local app on App Details (RocketChat#14894) * Unread counter added in popver * Get linked service account method added
Kailash0311
pushed a commit
to WideChat/Rocket.Chat
that referenced
this pull request
Jul 2, 2019
* [FIX] Load messages after disconnect and message box scroll missing (RocketChat#14668) * Removing unnecesary federation configs (RocketChat#14674) * [FIX] SAML login error. (RocketChat#14686) * Bump version to 1.1.1 * Service Account broadcast room callback added * Service Account Callback completed * CLI errors fixed * [NEW] Service Account one-tap login complete * Callbacks modified * Service Accounts directory tab added * [NEW] Service Accounts Login method * Typo fixed * CLI errors fixed * CLI errors fixed * [FIX] Anonymous chat read (RocketChat#14717) * Prevent errors when allowing anonymous read * getSingleMessage for anonymous users * Fix register user when allow read and write anonymous is enabled * Fix anonymous with sidebar extended as default Co-authored-by: ubergeekzone <ubergeekzone@gmail.com> * [FIX] User Real Name being erased when not modified (RocketChat#14711) * [FIX] User status information on User Info panel (RocketChat#14763) * [FIX] Anonymous chat read (RocketChat#14717) * Prevent errors when allowing anonymous read * getSingleMessage for anonymous users * Fix register user when allow read and write anonymous is enabled * Fix anonymous with sidebar extended as default Co-authored-by: ubergeekzone <ubergeekzone@gmail.com> * Bump version to 1.1.2 * [New] Service Account directory feature * CLI errors fixed * UsernameExists meteor method fixed * Sync commit * [NEW] Add loading animation to webdav file picker (RocketChat#14759) * [NEW] Service Account subscription method added * changed mongo version for snap from 3.2.7 to 3.4.20 (RocketChat#14838) * add _hidden for messages loaded by thread (RocketChat#14837) * Regression: thread loading parent msg if is not loaded (RocketChat#14839) * [IMPROVE] Layout of livechat manager pages to new style (RocketChat#13900) * [FIX] Removes E2E action button, icon and banner when E2E is disabled. (RocketChat#14810) * add _hidden for messages loaded by thread (RocketChat#14837) * Regression: thread loading parent msg if is not loaded (RocketChat#14839) * Bump version to 1.1.3 * [IMPROVE] Adds link to download generated user data file (RocketChat#14175) * [FIX] Error when using Download My Data or Export My Data (RocketChat#14645) * [NEW] Custom User Status (RocketChat#13933) Co-Authored-By: Tasso Evangelista <tasso@tassoevan.me> Co-Authored-By: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-Authored-By: wreiske <wreiske@mieweb.com> * Bump version to 1.2.0-rc.0 * Allow debugging of cached collections by name (RocketChat#14859) * Regression: Allow debugging of cached collections by name (RocketChat#14862) * Regression: Fix desktop notifications not being sent (RocketChat#14860) * Broadcast Room name change handled * Lint errors fixed * getLoginToken method refactored * Console statements removed * Sidebar header permission modified * Merge branch service-accounts * Added service account directory search translation key * Subscribers count added * [FIX] Custom status fixes (RocketChat#14853) * Fixes for status message text presence issues Added statusText to several api endpoints Changed statusMessage to statusText since that is what it is called everywhere * Fixed slash command for changing status * Fixed the "name is required" issue * Make sure the status is set blank if selecting a default status... we don't want an "online" status when someone is actually offline! * Fixes display of custom status on the room header * Changed the header of DM rooms to query the server for the user status text when it is not found on the internal collection * Changed Custom Status methods to check if the user is logged in * Improved code readability * Fix getting status list before logging in * Bump version to 1.2.0-rc.1 * [FIX] LinkedIn OAuth login (RocketChat#14887) * [NEW] Show App bundles and its apps (RocketChat#14886) * Bump version to 1.2.0-rc.2 * Bump version to 1.2.0 * Bump version to 1.3.0-develop * [FIX] Not showing local app on App Details (RocketChat#14894) * Unread counter added in popver * Get linked service account method added * get cloud generated public key for marketplace licenses (RocketChat#14851)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #ISSUE_NUMBER