Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.1.3 #14850

Merged
merged 3 commits into from
Jun 21, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .docker/Dockerfile.rhel
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM registry.access.redhat.com/rhscl/nodejs-8-rhel7

ENV RC_VERSION 1.1.2
ENV RC_VERSION 1.1.3

MAINTAINER buildmaster@rocket.chat

Expand Down
30 changes: 30 additions & 0 deletions .github/history.json
Original file line number Diff line number Diff line change
Expand Up @@ -31883,6 +31883,36 @@
]
}
]
},
"1.1.3": {
"node_version": "8.11.4",
"npm_version": "6.4.1",
"mongo_versions": [
"3.2",
"3.4",
"3.6",
"4.0"
],
"pull_requests": [
{
"pr": "14839",
"title": "Regression: thread loading parent msg if is not loaded",
"userLogin": "ggazzo",
"milestone": "1.1.3",
"contributors": [
"ggazzo"
]
},
{
"pr": "14837",
"title": "[FIX] Gap of messages when loading history when using threads",
"userLogin": "ggazzo",
"milestone": "1.1.3",
"contributors": [
"ggazzo"
]
}
]
}
}
}
2 changes: 1 addition & 1 deletion .travis/snap.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ elif [[ $TRAVIS_TAG ]]; then
RC_VERSION=$TRAVIS_TAG
else
CHANNEL=edge
RC_VERSION=1.1.2
RC_VERSION=1.1.3
fi

echo "Preparing to trigger a snap release for $CHANNEL channel"
Expand Down
23 changes: 23 additions & 0 deletions HISTORY.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,27 @@

# 1.1.3
`2019-06-21 · 1 🐛 · 1 🔍 · 1 👩‍💻👨‍💻`

### Engine versions
- Node: `8.11.4`
- NPM: `6.4.1`
- MongoDB: `3.2, 3.4, 3.6, 4.0`

### 🐛 Bug fixes

- Gap of messages when loading history when using threads ([#14837](https://github.com/RocketChat/Rocket.Chat/pull/14837))

<details>
<summary>🔍 Minor changes</summary>

- Regression: thread loading parent msg if is not loaded ([#14839](https://github.com/RocketChat/Rocket.Chat/pull/14839))

</details>

### 👩‍💻👨‍💻 Core Team 🤓

- [@ggazzo](https://github.com/ggazzo)

# 1.1.2
`2019-06-17 · 3 🐛 · 4 👩‍💻👨‍💻`

Expand Down
25 changes: 13 additions & 12 deletions app/ui-message/client/message.js
Original file line number Diff line number Diff line change
Expand Up @@ -429,33 +429,34 @@ Template.message.helpers({

const findParentMessage = (() => {
const waiting = [];

const uid = Tracker.nonreactive(() => Meteor.userId());
const getMessages = _.debounce(async function() {
const uid = Tracker.nonreactive(() => Meteor.userId());
const _tmp = [...waiting];
waiting.length = 0;
(await call('getMessages', _tmp)).map((msg) => upsertMessage({ msg, uid }));
(await call('getMessages', _tmp)).map((msg) => Messages.findOne({ _id: msg._id }) || upsertMessage({ msg: { ...msg, _hidden: true }, uid }));
}, 500);


return (tmid) => {
if (waiting.indexOf(tmid) > -1) {
return;
}

const message = Messages.findOne({ _id: tmid });
if (message) {
const uid = Tracker.nonreactive(() => Meteor.userId());
return Messages.update({ tmid, repliesCount: { $exists: 0 } }, {
if (!message) {
waiting.push(tmid);
return getMessages();
}
return Messages.update(
{ tmid, repliesCount: { $exists: 0 } },
{
$set: {
following: message.replies && message.replies.indexOf(uid) > -1,
threadMsg: normalizeThreadMessage(message),
repliesCount: message.tcount,
},
}, { multi: true });
}

waiting.push(tmid);
getMessages();
},
{ multi: true }
);
};
})();

Expand Down
2 changes: 1 addition & 1 deletion app/utils/rocketchat.info
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"version": "1.1.2"
"version": "1.1.3"
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "Rocket.Chat",
"description": "The Ultimate Open Source WebChat Platform",
"version": "1.1.2",
"version": "1.1.3",
"author": {
"name": "Rocket.Chat",
"url": "https://rocket.chat/"
Expand Down