Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Apps and Marketplace UI issues #15045

Merged
merged 64 commits into from
Jul 30, 2019
Merged
Show file tree
Hide file tree
Changes from 63 commits
Commits
Show all changes
64 commits
Select commit Hold shift + click to select a range
27394b2
Segregate Apps orchestrator and routes
tassoevan Jul 24, 2019
74d244f
Properly handle errors on orchestrator
tassoevan Jul 24, 2019
4ec6b20
Add i18n module to handle Apps translations
tassoevan Jul 24, 2019
a8b4b61
Update apps template
tassoevan Jul 24, 2019
9af34c3
Update marketplace template
tassoevan Jul 24, 2019
1c7fb26
Prefer rc-button on marketplace list
tassoevan Jul 25, 2019
bac927b
Ensure that a subscribed app will be installed
tassoevan Jul 25, 2019
ce79acd
Update appManage template (temp)
tassoevan Jul 25, 2019
a497090
Break promise chain in appManage template
tassoevan Jul 26, 2019
d135b14
Alert admins about apps on invalid state
rodrigok Jul 26, 2019
01aa3e5
Implement ui for warning and error alerts in apps
rodrigok Jul 26, 2019
216d69c
Open detail modal on viewing subscription info instead of the subscri…
geekgonecrazy Jul 26, 2019
81328a9
Implement ui for failed state of apps in detail screen
rodrigok Jul 26, 2019
75a8161
Fix appManage template data loading
tassoevan Jul 26, 2019
ad1e070
Use a simple history.back() to dismiss app logs
tassoevan Jul 26, 2019
e10a039
Share install button logic
tassoevan Jul 26, 2019
e3b33da
Ensure marketplaceVersion field on appManage template data
tassoevan Jul 26, 2019
0b13a35
Hide settings editing buttons if the app is not installed
tassoevan Jul 26, 2019
cf77a3c
Better handle errors in the apps api communicator
graywolf336 Jul 26, 2019
81859b3
Update events in appManage template
tassoevan Jul 26, 2019
b55562e
Merge branch 'fix/marketplace-ui' of github.com:RocketChat/Rocket.Cha…
tassoevan Jul 26, 2019
8f02d4a
Add getActiveLocalCount method to Users model
d-gubert Jul 26, 2019
455a965
Split button and status (partial)
tassoevan Jul 26, 2019
bdaf2df
Merge branch 'fix/marketplace-ui' of github.com:RocketChat/Rocket.Cha…
tassoevan Jul 26, 2019
6db949f
Fix appManage template state
tassoevan Jul 27, 2019
7cb2b2e
Add failure alert support into appManage
tassoevan Jul 27, 2019
aec20b7
Fix action to get free app from Marketplace
tassoevan Jul 27, 2019
91aa9d4
Update Trial button label
tassoevan Jul 27, 2019
b0f3c0e
Update category tag style
tassoevan Jul 27, 2019
1944e39
Add small tweaks to styles
tassoevan Jul 27, 2019
6241f45
Fix admin notification routine
d-gubert Jul 28, 2019
ec544db
Refactor admin notification
d-gubert Jul 28, 2019
f131257
Refactoring
d-gubert Jul 28, 2019
8665660
fix sync marketplace update
geekgonecrazy Jul 28, 2019
f351dba
Show validation erros/warnings on app detail page
d-gubert Jul 28, 2019
79bc264
Add status column to apps template
tassoevan Jul 29, 2019
b6f01b0
Fix Cloud login verification
tassoevan Jul 29, 2019
09aed68
Fix stylelint error
tassoevan Jul 29, 2019
c72715c
Move styles from marketplace template to all apps templates
tassoevan Jul 29, 2019
f35574a
Warn app status change only after user action
tassoevan Jul 29, 2019
e59ce71
Isolate app state to avoid memory leak
tassoevan Jul 29, 2019
d6958f1
Add route to Marketplace app
tassoevan Jul 29, 2019
4c07b49
React to app updates on appManage template
tassoevan Jul 29, 2019
1cd147e
Fix alert dimensions
tassoevan Jul 29, 2019
dd2aa12
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
tassoevan Jul 29, 2019
bc94274
Change app disable prompt wording
d-gubert Jul 29, 2019
faccf34
Fix disabled label on app detail
d-gubert Jul 29, 2019
8c44e97
Refactor appButtonProps and appStatusSpanProps
tassoevan Jul 29, 2019
c4cf86c
Fix typo
tassoevan Jul 29, 2019
984c574
Make AppWebsocketReceiver extend EventEmitter
tassoevan Jul 29, 2019
973ede7
Fix appErroredStatuses list
tassoevan Jul 29, 2019
581972b
Update uninstall modal
tassoevan Jul 29, 2019
1a5e529
Add missing i18n string
tassoevan Jul 29, 2019
bb0f010
Fix bug on modify subscription modal
tassoevan Jul 29, 2019
4dfed57
Add missing i18n string
tassoevan Jul 29, 2019
52b8de4
Get AppStatus structure from apps-engine
tassoevan Jul 29, 2019
82a6332
Fix uninstall message
tassoevan Jul 29, 2019
42a34bb
Change response to apps events
d-gubert Jul 29, 2019
1483021
Update app/apps/client/admin/helpers.js
tassoevan Jul 29, 2019
25eb1d3
Update modals
tassoevan Jul 30, 2019
2148c0c
Notify admins of disabled apps with valid licenses
d-gubert Jul 30, 2019
70739d7
Remove console.log
d-gubert Jul 30, 2019
a01e52f
Bump apps-engine version
d-gubert Jul 30, 2019
dbc1047
Merge branch 'develop' into fix/marketplace-ui
d-gubert Jul 30, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .stylelintignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
app/theme/client/vendor/fontello/css/fontello.css
packages/meteor-autocomplete/client/autocomplete.css
app/katex/katex.min.css
app/emoji-emojione/client/*.css
10 changes: 10 additions & 0 deletions app/api/server/api.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,16 @@ class APIClass extends Restivus {
};
}

internalError(msg) {
return {
statusCode: 500,
body: {
success: false,
error: msg || 'Internal error occured',
},
};
}

unauthorized(msg) {
return {
statusCode: 403,
Expand Down
206 changes: 96 additions & 110 deletions app/apps/assets/stylesheets/apps.css
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
letter-spacing: 0;
text-transform: initial;

color: #54585e;
color: var(--color-dark-medium);

font-size: 22px;
font-weight: normal;
Expand Down Expand Up @@ -60,94 +60,6 @@
line-height: 20px;
}

.rc-apps-details {
margin-bottom: 0;
padding: 0;

&__description {
padding-bottom: 50px;

border-bottom: 1.5px solid #efefef;
}

&__photo {
width: 96px;
height: 96px;
margin-right: 21px;

background-color: #f7f7f7;
}

&__content {
padding: 0;
}

&__col {
display: inline-block;

margin-right: 8px;
}

&__bundles {
display: flex;

padding-bottom: 20px;

border-bottom: 1.5px solid #efefef;
}

&__bundle {
display: flex;

width: 50%;
}

&__bundle_icons {
display: flex;
overflow: hidden;

min-width: 99px;
max-width: 99px;
height: 99px;

padding: 2px;

border-radius: 2px;

background-color: #e6e8eb;
flex-wrap: wrap;
}

&__bundle_icon {
min-width: 40px;
max-width: 40px;
height: 40px;

margin-top: 5px;
margin-left: 5px;

border-radius: 2px;

background-color: #f7f7f7;
background-repeat: no-repeat;
background-position: center center;
background-size: contain;
}

&__bundle_body {
padding: 5px 10px;

color: #9da1a7;

&_title {
color: #151924;

font-size: 1.1em;
font-weight: 500;
}
}
}

.rc-apps-container {
margin-top: 0;
padding-bottom: 15px;
Expand All @@ -156,7 +68,7 @@
.rc-apps-container__header {
padding-top: 10px;

border-bottom: 1.5px solid #efefef;
border-bottom: 1.5px solid var(--color-gray-lightest);
}

/*
Expand Down Expand Up @@ -190,7 +102,7 @@

color: #9da2a9;
border-radius: 2px;
background: #f3f4f5;
background: var(--color-gray-lightest);

font-size: 12px;
font-weight: 500;
Expand Down Expand Up @@ -240,22 +152,6 @@
padding-right: 10px;
}

td.rc-apps-marketplace-price {
text-align: right;

button {
font-weight: 600;
}

.rc-icon {
color: #3582f3;
}
}

th.rc-apps-marketplace-price {
width: 120px;
}

&__wrap-actions {
& > .loading {
display: none;
Expand Down Expand Up @@ -329,6 +225,14 @@
}
}

& tbody .rc-table-tr .rc-apps-section__app-menu-trigger {
visibility: hidden;
}

& tbody .rc-table-tr:hover .rc-apps-section__app-menu-trigger {
visibility: visible;
}

& tbody .rc-table-tr:not(.table-no-click):not(.table-no-pointer):hover {
background-color: #f7f8fa;
}
Expand Down Expand Up @@ -362,9 +266,8 @@
text-transform: none;
text-overflow: ellipsis;

color: #9da1a8;
border-radius: 9999px;
background-color: #eef0f3;
color: var(--color-gray);
background-color: var(--color-gray-lightest);

font-size: 0.625rem;
font-weight: 500;
Expand All @@ -382,6 +285,89 @@
}
}
}

&__app-menu-trigger {

position: relative;

display: flex;
flex: 0 0 auto;

margin-left: auto;
padding: 0;

font-size: 0.875rem;
line-height: 1.25rem;
align-items: center;
appearance: none;
margin-inline-start: auto;

&:active {
transform: translateY(2px);

opacity: 0.9;
}

&:active::before {
top: -2px;
}

&::before {
position: absolute;
top: 0;
right: 0;
bottom: 0;
left: 0;

content: "";
cursor: pointer;
}

& .rc-icon {
margin: 0;
}
}

&__spinning-icon {
animation: spin 1s linear infinite;
}

&__button--working {
opacity: 0.6;
}

&__status {
width: 100%;

color: var(--rc-color-primary-light);

line-height: 40px;

&--warning {
color: var(--rc-color-alert);
}

&--failed {
color: var(--rc-color-error);
}
}

&__status-column {
width: 150px;
}

tr .rc-apps-section__table-button--hideable {
visibility: hidden;
}

tr .rc-apps-section__table-button--working,
tr:hover .rc-apps-section__table-button--hideable {
visibility: visible;
}

.rc-apps-section__table-button--working {
opacity: 0.6;
}
}

@keyframes play90 {
Expand Down
4 changes: 2 additions & 2 deletions app/apps/client/admin/appLogs.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ Template.appLogs.events({
$(e.currentTarget).find('.button-down').removeClass('arrow-up');
},

'click .js-cancel': (e, t) => {
FlowRouter.go('app-manage', { appId: t.app.get().id }, { version: FlowRouter.getQueryParam('version') });
'click .js-cancel': () => {
FlowRouter.go('apps');
},

'click .js-refresh': (e, t) => {
Expand Down
Loading