Regression: New Livechat methods and processes #15242
Conversation
ggazzo
changed the title
…s not reactivity for Livechat Managers in some Livechat Templates. such as visitorInfo, visitorEdit and so on.
| @@ -9,7 +9,7 @@ Meteor.publish('livechat:rooms', function(filter = {}, offset = 0, limit = 20) { | |||
| return this.error(new Meteor.Error('error-not-authorized', 'Not authorized', { publish: 'livechat:rooms' })); | |||
| } | |||
|
|
|||
| if (!hasPermission(this.userId, 'view-livechat-rooms')) { | |||
| if (!hasPermission(this.userId, 'view-livechat-rooms') && !(filter._id && hasPermission(this.userId, 'view-l-room'))) { | |||
There was a problem hiding this comment.
I think it is always harder to read conditions like this, where you test the truth value but negates afterwards.
is this the same?
| if (!hasPermission(this.userId, 'view-livechat-rooms') && !(filter._id && hasPermission(this.userId, 'view-l-room'))) { | |
| if (!hasPermission(this.userId, 'view-livechat-rooms') && !(filter._id && hasPermission(this.userId, 'view-l-room'))) { | |
| if (!hasPermission(this.userId, 'view-livechat-rooms') || (filter._id && !hasPermission(this.userId, 'view-l-room'))) { |
There was a problem hiding this comment.
also is this the case where an agent is trying to view a room's data? in this case should we only allow it to view the data if he is the servedBy agent?
There was a problem hiding this comment.
Yeah, this is exactly that case.
I improved the code, so now it will check the right validation/permission just like your last question.
Thanks.
|
Hi @sampaiodiego! Thanks. |
renatobecker-zz
changed the title
renatobecker-zz
changed the title
|
@sampaiodiego
The documentation will be updated later. |
After reviewed the codebase where there are a lot of new implementations related to Livechat pull requests, I noticed that some methods needed improvements and fixes to work as well as expected.
Important change:
We're renaming the Livechat Routing methods, as described below:
Guest PooltoManual Selection;Least AmounttoAuto Selection;In addition: The Room model(client side) has been replaced with LivechatRoom model in some Livechat templates, such as
visitorInfoandvisitorEdit. This change was necessary because the reactivity was not working for Livechat Managers because the models based onCachedCollectiononly emit changes to the users who have the related subscription and the Livechat Managers have permission to access those templates even they don't have that subscription.This is a PR that needs to be merged before the next release ->
2.0.0.