[IMPROVE] Replace livechat:departments publication by REST Calls
#15478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosSpessatto
changed the title
MarcosSpessatto
changed the title
sampaiodiego
requested changes
Oct 3, 2019
| } | ||
| } | ||
| this.autorun(async () => { | ||
| const { department, agents } = await APIClient.v1.get(`livechat/department/${ FlowRouter.getParam('_id') }`); |
There was a problem hiding this comment.
it is currently doing the request even without an _id .. this request is only needed when editing a department
| const room = LivechatRoom.findOne({ _id: rid }); | ||
| this.visitorId.set(room && room.v && room.v._id); | ||
| this.departmentId.set(room && room.departmentId); | ||
| this.tags.set(room && room.tags); | ||
| const { department } = await APIClient.v1.get(`livechat/department/${ this.departmentId.get() }`); |
There was a problem hiding this comment.
this is being called on every message sent (due to changes on room object).
I recommend moving this GET to a separate autorun orbserving only this.departmentId
sampaiodiego
requested changes
Oct 4, 2019
sampaiodiego
approved these changes
Oct 4, 2019
sampaiodiego
changed the title
livechat:departments publication by REST Calls
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.