[NEW] add delete-own-message permission #15512
Conversation
|
@ggazzo need to improve the title! |
|
@rodrigok thinking more about, I dont think this pr is good enough, I'm using return |
…t.Chat into feat/delete-own-message
|
Will this be included in a release any time soon? It is greatly needed in my instance of Rocket chat. |
It's Open Source. So it will be included when it is ready... If you look it is in the 2.3.0 milestone. But that may slip depending on the developers priorities - what is important to you may not be so important to them.... Of course you can pay for support. Or your pull request with a fix will be welcomed. If not I'm afraid you will just have to be patient. |
|
@cchbr sure, we are planning to deliver in to the next release (2.3.0 or 3.0.0, November 27th), if you are running your own build, you can make a cherry pick :) |
Co-Authored-By: Tasso Evangelista <tasso.evangelista@rocket.chat>
|
This pull request introduces 1 alert when merging 436fad9 into 6c0e8d1 - view on LGTM.com new alerts:
|
| @@ -30,6 +30,7 @@ export function messageContext({ rid } = Template.instance()) { | |||
| showreply: true, | |||
| showReplyButton: true, | |||
| hasPermissionDeleteMessage: hasPermission('delete-message', rid), | |||
| hasPermissionDeleteOwnMessage: hasPermission('delete-own-message'), | |||
There was a problem hiding this comment.
is this being used somewhere?
There was a problem hiding this comment.
not yet, but hasPermissionDeleteMessage is not being used too, I just passing the context, and maybe after I could improve some stuffs.
Closes #5434