Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] Split logger classes to avoid cyclic dependencies #15559

Merged
merged 1 commit into from
Oct 11, 2019
Merged

[CHORE] Split logger classes to avoid cyclic dependencies #15559

merged 1 commit into from
Oct 11, 2019

Conversation

MarcosSpessatto
Copy link
Member

No description provided.

@MarcosSpessatto MarcosSpessatto added this to the 2.2.0 milestone Oct 10, 2019
renatobecker-zz
renatobecker-zz approved these changes Oct 10, 2019
View reviewed changes
Copy link

@renatobecker-zz renatobecker-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sampaiodiego sampaiodiego changed the title [IMPROVE] Split logger classes to avoid cyclic dependencies [CHORE] Split logger classes to avoid cyclic dependencies Oct 11, 2019
@sampaiodiego sampaiodiego merged commit a9042ab into develop Oct 11, 2019
@sampaiodiego sampaiodiego deleted the split-logger-to-avoid-cyclic-deps branch October 11, 2019 13:45
@rodrigok rodrigok mentioned this pull request Oct 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@renatobecker-zz renatobecker-zz renatobecker-zz approved these changes

Assignees
No one assigned
Labels
type: improvement
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcosSpessatto @renatobecker-zz @sampaiodiego