Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many fixes for RTL #1559

Closed
wants to merge 1 commit into from
Closed

Many fixes for RTL #1559

wants to merge 1 commit into from

Conversation

fduraibi
Copy link
Contributor

@fduraibi fduraibi commented Dec 3, 2015

  • A lot of fixes for RTL
  • Reformatting and alignment of the whole file.
  • The RTL interface seems perfect now and every thing I tested works.

@fduraibi
Many fixes for RTL
2bc1a17 
- A lot of fixes for RTL 
- Reformatting and alignment of the whole file.

* The RTL interface seems perfect now and every thing I tested works.
@engelgabriel
Copy link
Member

@fduraibi Thanks a lot for the help!!! I really appreciate it!

Can you preserve the original text formatting? Otherwise we can't see what has been changed. :(

@fduraibi
Copy link
Contributor Author

fduraibi commented Dec 3, 2015

@engelgabriel the original text was not formatted properly, so I fixed the indentations to match the base.less file by using only tabs and no spaces.

@engelgabriel
Copy link
Member

Ok.. let me fix the indentation first.. and commit your changes after.. so we can see.

@engelgabriel
Copy link
Member

@fduraibi can you pull again and merge the files?

@fduraibi
Copy link
Contributor Author

fduraibi commented Dec 3, 2015

ok

@fduraibi
Copy link
Contributor Author

fduraibi commented Dec 3, 2015

@engelgabriel I created a new request #1560

@fduraibi fduraibi closed this Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fduraibi @engelgabriel