Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Setting to only send plain text emails #16065

Merged
merged 5 commits into from
Feb 3, 2020
Merged

[NEW] Setting to only send plain text emails #16065

merged 5 commits into from
Feb 3, 2020

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok added this to the 3.0.0 milestone Dec 24, 2019
@rodrigok rodrigok changed the title Plain text email only [NEW] Setting to only send plain text emails Dec 24, 2019
@rodrigok rodrigok mentioned this pull request Jan 2, 2020
Closed
sampaiodiego
sampaiodiego requested changes Jan 8, 2020
View reviewed changes
app/lib/server/startup/email.js Outdated Show resolved Hide resolved
app/mailer/server/api.js Show resolved Hide resolved
@rodrigok @sampaiodiego
Update app/lib/server/startup/email.js
f176e96 
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
@reetp
Copy link

reetp commented Feb 1, 2020

Is there any good reason why this can't this get merged?

Systems using Rocket email html notification emails get blocked by spam filters for being junk - they either end up in Junk folders, or often get bounced entirely.

It isn't a security issue - plain text is more secure than html.

@sampaiodiego sampaiodiego merged commit b634bc4 into develop Feb 3, 2020
@sampaiodiego sampaiodiego deleted the plain-text-email-only branch February 3, 2020 19:21
ggazzo added a commit that referenced this pull request Feb 3, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
6663679 
…readmessages

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Setting to only send plain text emails (#16065)
  Regression: Fix status bar margins (#16438)
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  Fix index creation for apps_logs collection (#16401)
  Revert message properties validation (#16395)
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
  [FIX] Container heights (#16388)
  Regression: App deletion wasn’t returning the correct information (#16360)
gabriellsh added a commit that referenced this pull request Feb 3, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
1c5e65b 
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Setting to only send plain text emails (#16065)
d-gubert pushed a commit that referenced this pull request Feb 4, 2020
@rodrigok @d-gubert
[NEW] Setting to only send plain text emails (#16065)
279d175
ggazzo added a commit that referenced this pull request Feb 4, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into user…
03fe860 
…-presence-lazy

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Fix sending a message not scrolling to bottom (#16451)
  LingoHub based on develop (#16450)
  [IMPROVE] Changes App user's status when the app was enabled/disabled (#16392)
  [IMPROVE] Log as info level when Method Rate Limiters are reached (#16446)
  Use GitHub Actions to store builds (#16443)
  [NEW] Sort the Omnichannel Chat list according to the user preferences (#16437)
  Regression: recent opened rooms being marked as read (#16442)
  [FIX] Option to make a channel default  (#16433)
  [NEW] Setting to only send plain text emails (#16065)
  fix group
  Regression: Fix status bar margins (#16438)
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  Fix index creation for apps_logs collection (#16401)
  Revert message properties validation (#16395)
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
  [FIX] Container heights (#16388)
  fix group messages
gabriellsh added a commit that referenced this pull request Feb 4, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
ccd3e9a 
…pinned_messages_collapse

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] `stdout` streamer infinite loop (#16452)
  Regression: Fix sending a message not scrolling to bottom (#16451)
  LingoHub based on develop (#16450)
  [IMPROVE] Changes App user's status when the app was enabled/disabled (#16392)
  [IMPROVE] Log as info level when Method Rate Limiters are reached (#16446)
  Use GitHub Actions to store builds (#16443)
  [NEW] Sort the Omnichannel Chat list according to the user preferences (#16437)
  Regression: recent opened rooms being marked as read (#16442)
  [FIX] Option to make a channel default  (#16433)
  [NEW] Setting to only send plain text emails (#16065)
  fix group
  Regression: Fix status bar margins (#16438)
  fix group messages
ggazzo added a commit that referenced this pull request Feb 4, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into ui-k…
1b06f24 
…it.2.0-turbo

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Fix app user status change for non-existing user (#16458)
  [FIX] `stdout` streamer infinite loop (#16452)
  Regression: Fix sending a message not scrolling to bottom (#16451)
  LingoHub based on develop (#16450)
  [IMPROVE] Changes App user's status when the app was enabled/disabled (#16392)
  [IMPROVE] Log as info level when Method Rate Limiters are reached (#16446)
  Use GitHub Actions to store builds (#16443)
  [NEW] Sort the Omnichannel Chat list according to the user preferences (#16437)
  Regression: recent opened rooms being marked as read (#16442)
  [FIX] Option to make a channel default  (#16433)
  [NEW] Setting to only send plain text emails (#16065)
  Regression: Fix status bar margins (#16438)
ggazzo added a commit that referenced this pull request Feb 4, 2020
@ggazzo
Merge branch 'ui-kit.2.0-turbo' of github.com:RocketChat/Rocket.Chat …
c4ec872 
…into ui-kit.2.0-turbo

* 'ui-kit.2.0-turbo' of github.com:RocketChat/Rocket.Chat:
  Remove npm
  Update with error messages
  [IMPROVE] Log as info level when Method Rate Limiters are reached (#16446)
  Use GitHub Actions to store builds (#16443)
  [NEW] Sort the Omnichannel Chat list according to the user preferences (#16437)
  Regression: recent opened rooms being marked as read (#16442)
  [FIX] Option to make a channel default  (#16433)
  [NEW] Setting to only send plain text emails (#16065)
  Regression: Fix status bar margins (#16438)
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  fix close modals
  Update action trigger format
  typo
@rodrigok rodrigok mentioned this pull request Feb 13, 2020
Closed
@sampaiodiego sampaiodiego mentioned this pull request Feb 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@makibras makibras Awaiting requested review from makibras

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Plain Text Only Option for Email Notifications
3 participants
@rodrigok @reetp @sampaiodiego