Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint: Resolve complexity warnings #16114

Merged
merged 7 commits into from
Jan 30, 2020
Merged

Lint: Resolve complexity warnings #16114

merged 7 commits into from
Jan 30, 2020

Conversation

rodrigok
Copy link
Member

No description provided.

@rodrigok rodrigok added this to the 3.0.0 milestone Dec 31, 2019
ggazzo
ggazzo requested changes Jan 2, 2020
View reviewed changes
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just check my comments ;) thanks

app/lib/server/functions/getAvatarSuggestionForUser.js Show resolved Hide resolved
ggazzo
ggazzo previously approved these changes Jan 29, 2020
View reviewed changes
@rodrigok
Merge remote-tracking branch 'origin/develop' into resolve-complexity…
7b3f8ad 
…-warnings

# Conflicts:
#	tests/cypress/pageobjects/flex-tab.page.js
ggazzo
ggazzo previously approved these changes Jan 29, 2020
View reviewed changes
@rodrigok rodrigok merged commit 7df3bb7 into develop Jan 30, 2020
@rodrigok rodrigok deleted the resolve-complexity-warnings branch January 30, 2020 13:58
ggazzo added a commit that referenced this pull request Jan 30, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into ui-k…
e67e25b 
…it.2.0-turbo

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [BREAK] Hide system messages (#16243)
  [IMPROVE] Prevent "App user" from being deleted by the admin (#16373)
  [FIX] Adding 'lang' tag (#16375)
  Lint: Resolve complexity warnings (#16114)
  Fix Preview Docker image (#16379)
  [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252)
  [FIX] App removal was moving logs to the trash collection (#16362)
  [FIX] Role tags missing - Description field explanation (#16356)
  Regression: Rate limiter was not working due to Meteor internal changes (#16361)
  [FIX] Invite links usage by channel owners/moderators (#16176)
  Fix assets download on CI (#16352)
  Regression: Fix set name to alias validation (#16347)
  Send build artifacts to S3 (#16237)
  [NEW] Create a user for the Apps during installation (#15896)
  Add missing translations (#16150)
  fix slack cvs user importer (#16253)
  [FIX] The "click to load" text is hard-coded and not translated. (#16142)
gabriellsh added a commit that referenced this pull request Jan 31, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
6b95ccb 
…email-validation-message

* 'develop' of github.com:RocketChat/Rocket.Chat: (22 commits)
  [IMPROVE] Update katex version  (#16393)
  [FIX] Mail Msg Cancel button not closing the flexbar (#16263)
  [FIX] Highlight freezing the UI (#16378)
  [BREAK] Hide system messages (#16243)
  [IMPROVE] Prevent "App user" from being deleted by the admin (#16373)
  [FIX] Adding 'lang' tag (#16375)
  Lint: Resolve complexity warnings (#16114)
  Fix Preview Docker image (#16379)
  [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252)
  [FIX] App removal was moving logs to the trash collection (#16362)
  [FIX] Role tags missing - Description field explanation (#16356)
  Regression: Rate limiter was not working due to Meteor internal changes (#16361)
  [FIX] Invite links usage by channel owners/moderators (#16176)
  Fix assets download on CI (#16352)
  Regression: Fix set name to alias validation (#16347)
  Send build artifacts to S3 (#16237)
  [NEW] Create a user for the Apps during installation (#15896)
  Add missing translations (#16150)
  fix slack cvs user importer (#16253)
  [FIX] The "click to load" text is hard-coded and not translated. (#16142)
  ...
gabriellsh added a commit that referenced this pull request Jan 31, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
af3b171 
…pinned_messages_collapse

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Update katex version  (#16393)
  [FIX] Mail Msg Cancel button not closing the flexbar (#16263)
  [FIX] Highlight freezing the UI (#16378)
  [BREAK] Hide system messages (#16243)
  [IMPROVE] Prevent "App user" from being deleted by the admin (#16373)
  [FIX] Adding 'lang' tag (#16375)
  Lint: Resolve complexity warnings (#16114)
  Fix Preview Docker image (#16379)
  [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252)
  [FIX] App removal was moving logs to the trash collection (#16362)
  [FIX] Role tags missing - Description field explanation (#16356)
  Regression: Rate limiter was not working due to Meteor internal changes (#16361)
  [FIX] Invite links usage by channel owners/moderators (#16176)
  Fix assets download on CI (#16352)
  Regression: Fix set name to alias validation (#16347)
  Send build artifacts to S3 (#16237)
  [NEW] Create a user for the Apps during installation (#15896)
  Add missing translations (#16150)
  fix slack cvs user importer (#16253)
ggazzo added a commit that referenced this pull request Jan 31, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into uikit
ea2ec0a 
* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Container heights (#16388)
  Regression: App deletion wasn’t returning the correct information (#16360)
  [BREAK] Remove deprecated publications (#16351)
  [IMPROVE] Update katex version  (#16393)
  [FIX] Mail Msg Cancel button not closing the flexbar (#16263)
  [FIX] Highlight freezing the UI (#16378)
  [BREAK] Hide system messages (#16243)
  [IMPROVE] Prevent "App user" from being deleted by the admin (#16373)
  [FIX] Adding 'lang' tag (#16375)
  Lint: Resolve complexity warnings (#16114)
  Fix Preview Docker image (#16379)
  [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252)
  [FIX] App removal was moving logs to the trash collection (#16362)
  [FIX] Role tags missing - Description field explanation (#16356)
gabriellsh added a commit that referenced this pull request Feb 3, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
568f048 
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (46 commits)
  Regression: Fix status bar margins (#16438)
  [NEW] Check the Omnichannel service status per Department (#16425)
  [IMPROVE] Show more information related to the Omnichannel room closing data (#16414)
  Fix index creation for apps_logs collection (#16401)
  Revert message properties validation (#16395)
  [FIX] Rooms not being marked as read sometimes (#16397)
  Update apps engine to 1.12.0-beta.2496 (#16398)
  [FIX] Container heights (#16388)
  Regression: App deletion wasn’t returning the correct information (#16360)
  [BREAK] Remove deprecated publications (#16351)
  [IMPROVE] Update katex version  (#16393)
  [FIX] Mail Msg Cancel button not closing the flexbar (#16263)
  [FIX] Highlight freezing the UI (#16378)
  [BREAK] Hide system messages (#16243)
  [IMPROVE] Prevent "App user" from being deleted by the admin (#16373)
  [FIX] Adding 'lang' tag (#16375)
  Lint: Resolve complexity warnings (#16114)
  Fix Preview Docker image (#16379)
  [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252)
  [FIX] App removal was moving logs to the trash collection (#16362)
  ...
ggazzo added a commit that referenced this pull request Feb 3, 2020
@ggazzo
Merge branch 'system-messages' of github.com:RocketChat/Rocket.Chat i…
5315cf7 
…nto system-messages

* 'system-messages' of github.com:RocketChat/Rocket.Chat:
  [BREAK] Hide system messages (#16243)
  [IMPROVE] Prevent "App user" from being deleted by the admin (#16373)
  [FIX] Adding 'lang' tag (#16375)
  Lint: Resolve complexity warnings (#16114)
  Fix Preview Docker image (#16379)
  [BREAK] Upgrade to Meteor 1.9 and NodeJS 12 (#16252)
  [FIX] App removal was moving logs to the trash collection (#16362)
  [FIX] Role tags missing - Description field explanation (#16356)
  Regression: Rate limiter was not working due to Meteor internal changes (#16361)
  [FIX] Invite links usage by channel owners/moderators (#16176)
  Fix assets download on CI (#16352)
@sampaiodiego sampaiodiego mentioned this pull request Feb 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rodrigok @ggazzo