-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Apps] Lazy load categories and marketplaceVersion in admin - apps page #16258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiqimei
changed the title
Lazy load categories and marketplaceVersion in admin - apps page
[Apps] Lazy load categories and marketplaceVersion in admin - apps page
Jan 15, 2020
This makes total sense for me, but I'll wait for @tassoevan's considerations 😬 |
tassoevan
previously approved these changes
Feb 26, 2020
d-gubert
approved these changes
Feb 28, 2020
gabriellsh
added a commit
to AgentTNT/Rocket.Chat
that referenced
this pull request
Feb 28, 2020
…6728-TheGr8Wonder-prune-granular * 'develop' of github.com:RocketChat/Rocket.Chat: [FIX] Cannot edit Profile when Full Name is empty and not required (RocketChat#16744) [IMPROVE] Accept open formarts of text, spreadsheet, presentation for upload by default (RocketChat#16502) Removing Trailing Space (RocketChat#16470) Lazy load categories and marketplaceVersion (RocketChat#16258)
gabriellsh
added a commit
to Pranav2612000/Rocket.Chat
that referenced
this pull request
Mar 3, 2020
…6643-Pranav2612000-develop * 'develop' of github.com:RocketChat/Rocket.Chat: (71 commits) Fix omnichannel icon missing on sidebar (RocketChat#16775) [IMPROVE] Rename client-side term "Livechat" to "Omnichannel" (RocketChat#16752) [FIX] Language country has been ignored on translation load (RocketChat#16757) [FIX] Cannot edit Profile when Full Name is empty and not required (RocketChat#16744) [IMPROVE] Accept open formarts of text, spreadsheet, presentation for upload by default (RocketChat#16502) Removing Trailing Space (RocketChat#16470) Lazy load categories and marketplaceVersion (RocketChat#16258) Fix Docker preview image (RocketChat#16736) [FIX] Manual Register use correct state for determining registered (RocketChat#16726) [FIX] Rocket.Chat takes too long to set the username when it fails to send enrollment email (RocketChat#16723) [CHORE] Changed remaining SelectInput's to Select (RocketChat#16719) [CHORE] Update snap install instructions (RocketChat#16720) [FIX] TypeError when trying to load avatar of an invalid room. (RocketChat#16699) [FIX] Color setting editing issues (RocketChat#16706) [FIX] Console error on login (RocketChat#16704) [NEW] Add methods to include room types on dashboard (RocketChat#16576) [FIX] ie11 support (RocketChat#16682) Regression: Show upload errors (RocketChat#16681) [FIX] Delete messages while searching bug (RocketChat#16568) Use insertSync ...
Merged
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
(Waiting around one minute until the apps list displays 🙊The `appsFromMarketPlace` blocks the UI for quite a long time, we can do nothing in this period. )
It will be great if we can load and display the installed apps first and then update the list when it is finished.
After: