Exclude federated and app users from active user count #16489
Conversation
| statistics.totalUsers = Meteor.users.find().count(); | ||
| statistics.activeUsers = Meteor.users.find({ active: true }).count(); | ||
| statistics.totalUsers = Users.find().count(); | ||
| statistics.activeUsers = Users.getActiveLocalUserCount(); |
There was a problem hiding this comment.
This is so it excludes remote and app users right?
Can we add app users like we have with federated users below? Would be probably useful to know how many app users specifically like we have with remote users
There was a problem hiding this comment.
Yes, I think we should add the count of app users
I say no. Because they aren't deactivated they just aren't considered active users
Yes to app users! We already have federated user count |
|
There is already one item of the total count of apps on the server... do you think it is still useful to know the count of app users? @geekgonecrazy @rodrigok |
|
@d-gubert I think so, it's directly related right now but this may change in the future. |
|
Agreed! I think its still useful to be able to make sense of the user totals. |
…5997-ritwizsinha-15996 * 'develop' of github.com:RocketChat/Rocket.Chat: (181 commits) Update Livechat widget dependency version to 1.3.1. (RocketChat#16580) Update Apps-Engine version (RocketChat#16584) [FIX] Error when successfully joining room by invite link (RocketChat#16571) Add breaking notice regarding TLS (RocketChat#16575) [FIX] Invite links proxy URLs not working when using CDN (RocketChat#16581) Regression: Modal onSubmit (RocketChat#16556) Regression: UIkit input states (RocketChat#16552) [FIX] Do not stop on DM imports if one of users was not found (RocketChat#16547) [FIX] Introduce AppLivechatBridge.isOnlineAsync method (RocketChat#16467) Regression: UIKit missing select states: error/disabled (RocketChat#16540) [BREAK] Change apps/icon endpoint to return app's icon and use it to show on Ui Kit modal (RocketChat#16522) Regression: update package-lock (RocketChat#16528) Regression: Update Uikit (RocketChat#16515) Regression: UIKit - Send container info on block actions triggered on a message (RocketChat#16514) Use base64 for import files upload to prevent file corruption (RocketChat#16516) Regression: Ui Kit messaging issues RocketChat#16513 Regression: Send app info along with interaction payload to the UI (RocketChat#16511) Fix: License missing from manual register handler (RocketChat#16505) Exclude federated and app users from active user count (RocketChat#16489) Remove users.info being called without need (RocketChat#16504) ...
This PR makes the active user count of the statistics stop taking app and federated users into consideration
Before
After
Criteria for active users
Things to consider: