Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Send files over REST API #16617

Merged
merged 5 commits into from
Feb 21, 2020
Merged

[IMPROVE] Send files over REST API #16617

merged 5 commits into from
Feb 21, 2020

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 17, 2020

No description provided.

@ggazzo ggazzo changed the title [IMPROVE] - send files over rest api [IMPROVE] Send files over rest api Feb 17, 2020
@ggazzo ggazzo requested a review from sampaiodiego February 17, 2020 14:41
@ggazzo ggazzo added the ui/ux label Feb 17, 2020
@ggazzo ggazzo added this to the 3.1.0 milestone Feb 17, 2020
app/utils/client/lib/RestApiClient.js Outdated Show resolved Hide resolved
app/utils/client/lib/RestApiClient.js Outdated Show resolved Hide resolved
ggazzo and others added 2 commits February 17, 2020 13:52
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
Co-Authored-By: Diego Sampaio <chinello@gmail.com>
@ggazzo ggazzo requested a review from sampaiodiego February 17, 2020 18:03
@geekgonecrazy
Copy link
Contributor

I think we still need to look at chunking or multi-part. Most proxies are going to have 20MB limit for payload. Even on cloud we limit to 20MB payload I believe.

I think only reason this hasn't been an issue before is because mobile has been the only one really sending files this way until now.

@recklessnl
Copy link

@geekgonecrazy Thanks for looking into this issue. Especially on local networks, the transfer speed should roughly match the general transfer speed of the network, and that currently isn't even close.

On my network, for example, I can transfer files to the same Rocket.Chat server a 125MB/s, maximizing the gigabit connection. I cannot get anywhere near this with Rocket Chat file transfers, as explained in #16542.

Even a 20MB limit would probably already help tremendously, but ideally this would be a tuneable setting in the admin console, as purely local networks need not to worry about these proxy limits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants