Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Add file-title and file-desc as new filter tag options on message search #16858

Merged
merged 3 commits into from
Apr 21, 2020

Conversation

subham103
Copy link
Contributor

@subham103 subham103 commented Mar 12, 2020

closed #11584
Currently, when we upload a file we can't find it by searching messages. Add option for search in a message using file title (title:TITLE_NAME) and file description (desc:DESCRIPTION)

pr7_1

@engelgabriel engelgabriel requested a review from rodrigok March 19, 2020 18:23
@engelgabriel engelgabriel added this to the 3.1.0 milestone Mar 19, 2020
@engelgabriel engelgabriel modified the milestones: 3.1.0, 3.2.0 Apr 20, 2020
server/methods/messageSearch.js Outdated Show resolved Hide resolved
server/methods/messageSearch.js Outdated Show resolved Hide resolved
server/methods/messageSearch.js Outdated Show resolved Hide resolved
@rodrigok rodrigok changed the title [IMPROVE] add option for description and title search [IMPROVE] Add file-title and file-desc as new filter tag options on message search Apr 21, 2020
@rodrigok rodrigok merged commit 9fd381e into RocketChat:develop Apr 21, 2020
@luixxiul
Copy link

Will this option be enabled by default on 3.2.0?

@rodrigok
Copy link
Member

@luixxiul yes

@luixxiul
Copy link

Thanks for the quick reply 😄

gabriellsh added a commit that referenced this pull request Apr 22, 2020
…users_and_rooms

* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits)
  [FIX] 2FA not showing codes for Spanish translation (#17378)
  [NEW] [ENTERPRISE] Restrict the permissions configuration for guest users  (#17333)
  [NEW] Federation event for when users left rooms (#17091)
  [FIX] CSV Importer fails when there are no users to import (#16790)
  Import slack's mpims as direct rooms instead of private groups (#17206)
  [FIX] SAML Idp Initiated Logout Error (#17324)
  [NEW] Better Push and Email Notification logic (#17357)
  [NEW] Error page when browser is not supported (#17372)
  [NEW] [ENTERPRISE] Omnichannel queue priorities (#17141)
  [IMPROVE] Change the SAML metadata order to conform to XSD specification (#15488)
  [IMPROVE] Filter markdown in notifications (#9995)
  [IMPROVE] User gets UI feedback when message is pinned or unpinned (#16056)
  Remove set as alias setting (#16343)
  [IMPROVE] Add `file-title` and `file-desc` as new filter tag options on message search (#16858)
  [NEW]  Add ability to set tags in the Omnichannel room closing dialog (#17254)
  [FIX] Show active admin and user account menu item (#17047)
  [NEW] [ENTERPRISE] Allows to set a group of departments accepted for forwarding chats (#17335)
  [FIX] Prevent user from getting stuck on login, if there is some bad fname (#17331)
  [FIX] Remove properties from users.info response (#17238)
  Bump version to 3.1.1
  ...
@sampaiodiego sampaiodiego mentioned this pull request Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Take attachment comments into account when message searching
4 participants