Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Make the AppLivechatBridge.createMessage works properly as a promise #16941

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Fix: Make the AppLivechatBridge.createMessage works properly as a promise #16941

merged 1 commit into from
Mar 20, 2020

Conversation

renatobecker
Copy link
Contributor

There was a await statement missing, so the Apps weren't getting the expected return value.

@renatobecker renatobecker added this to the 3.1.0 milestone Mar 19, 2020
@rodrigok rodrigok merged commit b060e07 into develop Mar 20, 2020
@rodrigok rodrigok deleted the omnichannel/turn-app-livechat-bridge-create-message-promise branch March 20, 2020 00:21
@rodrigok rodrigok changed the title [FIX] Make the AppLivechatBridge.createMessage works properly as a promise Fix: Make the AppLivechatBridge.createMessage works properly as a promise Mar 26, 2020
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

@d-gubert d-gubert Awaiting requested review from d-gubert

@shiqimei shiqimei Awaiting requested review from shiqimei

Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@renatobecker @rodrigok