-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] [Apps-Engine] App user as the default notifier #17050
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The app for testing: import {
IAppAccessors,
IHttp,
ILogger,
IModify,
IPersistence,
IRead,
} from '@rocket.chat/apps-engine/definition/accessors';
import { App } from '@rocket.chat/apps-engine/definition/App';
import { IMessage, IPostMessageSent } from '@rocket.chat/apps-engine/definition/messages';
import { IAppInfo } from '@rocket.chat/apps-engine/definition/metadata';
export class NotifyUserApp extends App implements IPostMessageSent {
constructor(info: IAppInfo, logger: ILogger, accessors: IAppAccessors) {
super(info, logger, accessors);
}
public async executePostMessageSent(message: IMessage, read: IRead, http: IHttp, persistence: IPersistence, modify: IModify): Promise<void> {
const { sender, room, text } = message;
const messageBuilder = modify.getCreator().startMessage({ room, text } as IMessage);
await read.getNotifier().notifyUser(sender, messageBuilder.getMessage());
await read.getNotifier().notifyUser(sender, message);
await read.getNotifier().notifyRoom(room, messageBuilder.getMessage());
return read.getNotifier().notifyRoom(room, message);
}
} |
d-gubert
requested changes
Mar 27, 2020
d-gubert
reviewed
Apr 8, 2020
d-gubert
approved these changes
Apr 28, 2020
d-gubert
changed the title
[Apps] App user as the default notifier
[IMPROVE] [Apps-Engine] App user as the default notifier
Apr 28, 2020
d-gubert
added a commit
that referenced
this pull request
May 1, 2020
* App user as the default notifier * Move changes to the apps-engine side Co-authored-by: Douglas Gubert <d-gubert@users.noreply.github.com>
dudizilla
added a commit
that referenced
this pull request
May 4, 2020
….Chat into custom-emoji * 'admin-refactor' of https://github.com/RocketChat/Rocket.Chat: LingoHub based on develop (#17520) RegExp improvements suggested by LGTM (#17500) [FIX] Replace obsolete X-FRAME-OPTIONS header on Livechat route (#17419) [FIX] LDAP login error on Enterprise version (#17497) [IMPROVE] [Apps-Engine] App user as the default notifier (#17050) [NEW] [Apps-Engine] New Livechat event handlers (#17033) [FIX] Change email verification label (#17450) fix: Admin Users Actions (#17469) Fix bad component reference [IMPROVE] Depart from /app/ui-admin (#17464) Priority system messages were always created (#17479) Bump version to 3.3.0-develop Bump version to 3.2.0 Bump version to 3.2.0-rc.2 Bump version to 3.2.0-rc.1 Bump version to 3.2.0-rc.0
ggazzo
added a commit
that referenced
this pull request
May 6, 2020
…/new-threads * 'develop' of github.com:RocketChat/Rocket.Chat: (42 commits) [FIX] Invalid CSS syntax (#17541) [NEW] Rewrite admin pages (#17388) [FIX] Replace postcss Meteor package (#15929) [FIX] Increasing highlight time in 3 seconds (#17540) [IMPROVE] Add new webhooks to the Omnichannel integration feature (#17503) [BREAK] Remove deprecated Omnichannel Knowledge Base feature (#17387) [FIX] Reactions may present empty names of who reacted when using Real Names (#17536) Allow to filter omnichannel analytics dashboards per departments. (#17463) [FIX] Uncessary updates on Settings, Roles and Permissions on startup (#17160) [NEW] Add the ability to send Livechat offline messages to a channel (#17442) [FIX] Federation attachment URL for audio and video files (#16430) [NEW] Add Livechat website URL to the offline message e-mail (#17429) LingoHub based on develop (#17520) RegExp improvements suggested by LGTM (#17500) [FIX] Replace obsolete X-FRAME-OPTIONS header on Livechat route (#17419) [FIX] LDAP login error on Enterprise version (#17497) [IMPROVE] [Apps-Engine] App user as the default notifier (#17050) [NEW] [Apps-Engine] New Livechat event handlers (#17033) [FIX] Change email verification label (#17450) Priority system messages were always created (#17479) ...
ggazzo
added a commit
that referenced
this pull request
May 6, 2020
* 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits) [IMPROVE] [Apps-Engine] App user as the default notifier (#17050) [NEW] [Apps-Engine] New Livechat event handlers (#17033) [FIX] Change email verification label (#17450) Priority system messages were always created (#17479) Bump version to 3.3.0-develop Bump version to 3.2.0 Bump version to 3.1.2 [FIX] LDAP error when trying to add room with spaces in the name (#17453) Regression: Add missing cacheKey to mem (#17430) [FIX] Empty Incoming webhook script field (#17422) [FIX] LDAP Sync error (#17417) [FIX] Bot Agents not being able to get Omnichannel Inquiries (#17404) [FIX] Allowing blocking a user on channels (#17406) Regression: Fix mem usage with more than one argument (#17391) [FIX] Web Client memory leak caused by the Emoji library (#17320) [FIX] Omnichannel room info panel opening whenever a message is sent (#17348) [FIX] New user added by admin doesn't receive random password email (#17249) Bump version to 3.2.0-rc.2 [FIX] LDAP error when trying to add room with spaces in the name (#17453) Complement Guest role restrictions for Enterprise (#17393) ...
gabriellsh
added a commit
that referenced
this pull request
May 6, 2020
…to integrations * 'admin-refactor' of github.com:RocketChat/Rocket.Chat: LingoHub based on develop (#17520) RegExp improvements suggested by LGTM (#17500) [FIX] Replace obsolete X-FRAME-OPTIONS header on Livechat route (#17419) [FIX] LDAP login error on Enterprise version (#17497) [IMPROVE] [Apps-Engine] App user as the default notifier (#17050) [NEW] [Apps-Engine] New Livechat event handlers (#17033) [FIX] Change email verification label (#17450) Priority system messages were always created (#17479) Bump version to 3.3.0-develop Bump version to 3.2.0 Bump version to 3.2.0-rc.2 Bump version to 3.2.0-rc.1 Bump version to 3.2.0-rc.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on RocketChat/Rocket.Chat.Apps-engine#255
Closes #17046