Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Do not refresh statistics when opening the info panel #17060

Merged
merged 1 commit into from
Mar 28, 2020
Merged

Regression: Do not refresh statistics when opening the info panel #17060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions client/components/admin/info/InformationRoute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export function InformationRoute() {
useEffect(() => {
let didCancel = false;

const fetchStatistics = async () => {
const fetchStatistics = async ({ refresh = false } = {}) => {
if (!canViewStatistics) {
setStatistics(null);
setInstances(null);
Expand All @@ -32,7 +32,7 @@ export function InformationRoute() {

try {
const [statistics, instances] = await Promise.all([
getStatistics({ refresh: true }),
getStatistics({ refresh }),
getInstances(),
]);

Expand Down Expand Up @@ -62,7 +62,7 @@ export function InformationRoute() {
return;
}

fetchStatistics();
fetchStatistics({ refresh: true });
};

const handleClickDownloadInfo = () => {
Expand Down