Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Support importing Slack threads #17130

Merged
merged 4 commits into from
Apr 13, 2020

Conversation

lpilz
Copy link
Contributor

@lpilz lpilz commented Apr 1, 2020

Closes #6833
Closes #16883

d584a3c Adds support for the importing of threads in the slack-importer.

  • for Parent Comment fills replies, tcount and tlm fields
  • for Child (with or without attachment) fills tmid

a2b57f7 Adds support for thread_broadcast message subtype

  • Adds thread_broadcast messages from slack as normal thread messages
    • important for consistency of thread discussion, one could also think about maybe adding the thread_broadcast message to the channel too.
  • changes call signature of processMessageSubType to add slackChannel
    • could possibly also extract it from message.ts, but this is kinda hacky
  • does not support the message.files field as of yet, this would considerably increase complexity and might necessitate outsourcing it to a new subroutine

@CLAassistant
Copy link

CLAassistant commented Apr 1, 2020

CLA assistant check
All committers have signed the CLA.

@lpilz lpilz force-pushed the feat/slack-importer-threads branch from a2b57f7 to 2e34181 Compare April 3, 2020 14:44
@lpilz
Copy link
Contributor Author

lpilz commented Apr 3, 2020

Rebased the branch

@lpilz lpilz force-pushed the feat/slack-importer-threads branch from 2e34181 to 77ac10a Compare April 3, 2020 16:42
@lpilz
Copy link
Contributor Author

lpilz commented Apr 3, 2020

Changed support of 'thread_broadcast' subtype to just catch it at the if(message.subtype) clause and treat it as a normal thread child message -> lower complexity, support for all fields included, no changes in call signature

@lpilz lpilz marked this pull request as ready for review April 5, 2020 14:04
@pierre-lehnen-rc pierre-lehnen-rc self-assigned this Apr 7, 2020
@lpilz
Copy link
Contributor Author

lpilz commented Apr 8, 2020

Cheers for the approve :) Seems I can't merge it, so I'll just wait for you guys to do it.
Do you know which release this code will be in?

@sampaiodiego sampaiodiego changed the title [NEW] Feat/slack importer threads [NEW] Support importing Slack threads Apr 13, 2020
@sampaiodiego sampaiodiego merged commit 0fde98e into RocketChat:develop Apr 13, 2020
@lpilz lpilz deleted the feat/slack-importer-threads branch April 19, 2020 13:34
@sampaiodiego sampaiodiego mentioned this pull request Apr 27, 2020
@engelgabriel engelgabriel added this to the 3.2.0 milestone May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack threads get imported as individual messages Threaded messages missing from Slack import
5 participants