-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Support importing Slack threads #17130
Merged
sampaiodiego
merged 4 commits into
RocketChat:develop
from
lpilz:feat/slack-importer-threads
Apr 13, 2020
Merged
[NEW] Support importing Slack threads #17130
sampaiodiego
merged 4 commits into
RocketChat:develop
from
lpilz:feat/slack-importer-threads
Apr 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpilz
force-pushed
the
feat/slack-importer-threads
branch
from
April 3, 2020 14:44
a2b57f7
to
2e34181
Compare
Rebased the branch |
…hread child for now.
lpilz
force-pushed
the
feat/slack-importer-threads
branch
from
April 3, 2020 16:42
2e34181
to
77ac10a
Compare
Changed support of 'thread_broadcast' subtype to just catch it at the |
pierre-lehnen-rc
approved these changes
Apr 7, 2020
Cheers for the approve :) Seems I can't merge it, so I'll just wait for you guys to do it. |
sampaiodiego
changed the title
[NEW] Feat/slack importer threads
[NEW] Support importing Slack threads
Apr 13, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6833
Closes #16883
d584a3c Adds support for the importing of threads in the slack-importer.
a2b57f7Adds support for thread_broadcast message subtypechanges call signature of processMessageSubType to add slackChannelcould possibly also extract it from message.ts, but this is kinda hackydoes not support the message.files field as of yet, this would considerably increase complexity and might necessitate outsourcing it to a new subroutine