fix URL #1717
Merged
fix URL #1717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs a slash, else url will look like this: `j.src = 'https://domain.tldpackages/rocketchat_livechat/assets/rocket-livechat.js';`
|
oh.. we have to check that trailing slash.. double slashes causes a 404.. |
sampaiodiego
added a commit
that referenced
this pull request
Dec 21, 2015
add trailing slash on ROOT_URL for livechat installation script
This was referenced Jan 11, 2022
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs a slash, else url will look like this:
j.src = 'https://domain.tldpackages/rocketchat_livechat/assets/rocket-livechat.js';