Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] SAML login errors not showing on UI #17219

Merged
merged 2 commits into from
Apr 8, 2020
Merged

Conversation

pierre-lehnen-rc
Copy link
Contributor

Closes #17085

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review April 8, 2020 16:01
@rodrigok rodrigok changed the title [FIX] SAML Login Errors [FIX] SAML login errors not showing on UI Apr 8, 2020
@rodrigok rodrigok added this to the 3.1.0 milestone Apr 8, 2020
@rodrigok rodrigok merged commit 44c4069 into develop Apr 8, 2020
@rodrigok rodrigok deleted the fix.saml-login-errors branch April 8, 2020 16:51
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
ggazzo added a commit that referenced this pull request Apr 10, 2020
…/admin-root

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Increase decoupling between React components and Blaze templates (#16642)
  Fix self DM (#17239)
  [CHORE] Use REST API for sending audio messages (#17237)
  [FIX] Random errors on SAML logout (#17227)
  Collect metrics about meteor facts (#17216)
  Removed the invalid and unnecessary parameter clientAction. (#17224)
  [FIX] Wrong SAML Response Signature Validation (#16922)
  [FIX] SAML login errors not showing on UI (#17219)
  Add statistics and metrics about push queue (#17208)
  Regression: Fix users raw model (#17204)
ggazzo added a commit that referenced this pull request Apr 10, 2020
…/admin-root

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Increase decoupling between React components and Blaze templates (#16642)
  Fix self DM (#17239)
  [CHORE] Use REST API for sending audio messages (#17237)
  [FIX] Random errors on SAML logout (#17227)
  Collect metrics about meteor facts (#17216)
  Removed the invalid and unnecessary parameter clientAction. (#17224)
  [FIX] Wrong SAML Response Signature Validation (#16922)
  [FIX] SAML login errors not showing on UI (#17219)
  Add statistics and metrics about push queue (#17208)
  Regression: Fix users raw model (#17204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SAML user creation randomly fail for some users
2 participants