Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Set retryWrites=false as default Mongo options #17683

Merged
merged 1 commit into from
May 19, 2020
Merged

Regression: Set retryWrites=false as default Mongo options #17683

merged 1 commit into from
May 19, 2020

Conversation

sampaiodiego
Copy link
Member

Proposed changes

When we updated to Meteor 1.10.x, Mongo npm package has updated to version 3.2 which is then using retryWrites: true as default.

This PR forces the option value to stay as it previously default value, which is false, as it would probably be a breaking change because retryWrites is support only by WiredTiger.

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

MongoDB docs https://docs.mongodb.com/manual/core/retryable-writes/#enabling-retryable-writes

@sampaiodiego sampaiodiego added this to the 3.3.0 milestone May 18, 2020
geekgonecrazy
geekgonecrazy approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@geekgonecrazy geekgonecrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for saving the day! :) This would have been a major headache :)

@sampaiodiego sampaiodiego merged commit 59c40d0 into develop May 19, 2020
@sampaiodiego sampaiodiego deleted the fix-retry-writes branch May 19, 2020 14:58
gabriellsh added a commit that referenced this pull request May 19, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
ac5c7a4 
…customFields_users

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Add env var to configure Chatpal URL and remove it from beta (#16665)
  Regression: Set retryWrites=false as default Mongo options (#17683)
  Fix the leak of agent's custom fields. (#17640)
  Regression: removed avatar provider temporary
  [FIX] Avatar url provider ignoring subfolders (#17675)
  [IMPROVE] Added divider between tables and paginations (#17680)
  [IMPROVE] Starred Messages  (#17685)
  Regression: status-color-online (#17684)
gabriellsh added a commit that referenced this pull request May 22, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
7fc4af0 
…apps_rewrite

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Integrations edit/history crashing (#17702)
  [FIX] Allow owners to react inside broadcast channels (#17687)
  Regression: User edit form missing fields (#17699)
  [FIX] Default filters on Omnichannel Current Chats screen not showing on first load (#17522)
  Update Helper.js (#17700)
  [FIX] UI KIT Modal Width (#17697)
  Update Contributing Guide (#17653)
  LingoHub based on develop (#17693)
  [NEW] Added custom fields to Add/Edit user (#17681)
  Regression: Fix incorrect imports of the Apps-Engine (#17695)
  Improve: Remove uncessary RegExp query by email (#17654)
  [NEW] [Apps-Engine] New Room events (#17487)
  [IMPROVE] Add env var to configure Chatpal URL and remove it from beta (#16665)
  Regression: Set retryWrites=false as default Mongo options (#17683)
This was referenced May 28, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geekgonecrazy geekgonecrazy geekgonecrazy approved these changes

@rodrigok rodrigok Awaiting requested review from rodrigok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sampaiodiego @geekgonecrazy