Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Add missing i18n entry for LDAP connection test success message #17691

Merged
merged 7 commits into from
Jun 22, 2020

Conversation

bytes-by-talari
Copy link
Contributor

@bytes-by-talari bytes-by-talari commented May 19, 2020

Closes #17382

Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request.. Can you please make the appropriate change? Thanks in advance

packages/rocketchat-i18n/i18n/en.i18n.json Outdated Show resolved Hide resolved
Addressed Requested Changes
@pierre-lehnen-rc pierre-lehnen-rc added this to the 3.4.0 milestone Jun 22, 2020
@sampaiodiego sampaiodiego changed the title [Fix] i18n missing for LDAP connection test success message Closes #17382 [FIX] Add missing i18n entry for LDAP connection test success message Jun 22, 2020
@sampaiodiego sampaiodiego merged commit c9333af into RocketChat:develop Jun 22, 2020
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n missing for LDAP connection test success message
4 participants