Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo on Contributing.md #17769

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Fix typo on Contributing.md #17769

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9675616
Typo on Contributing.md
onurtemiz May 28, 2020
efadc8e
Merge branch 'develop' into patch-1
engelgabriel Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ __Note:__ If there's a feature you'd like, there's a bug you'd like to fix, or y

## Setup

Your development workstation needs to have at least 8GB or RAM to be able to build the Rocket.Chat's source code.
Your development workstation needs to have at least 8GB RAM or more to be able to build the Rocket.Chat's source code.

Rocket.Chat runs on top of [Meteor](https://www.meteor.com/). To run it on development mode you need to [install Meteor](https://www.meteor.com/install) and clone/download the Rocket.Chat's code, then just open the code folder and run:
```shell
Expand Down Expand Up @@ -241,7 +241,7 @@ All those PRs will be grouped under the `Minor changes` section which is collaps

- Prefer inform the fields you want, and only the necessary ones, when querying data from database over query the full documents
- Limit the number of returned records to a reasonable value
- Check if the query is using indexes, it it's not create new indexes
- Check if the query is using indexes, if it's not create new indexes
- Prefer queues over long executions
- Create new metrics to mesure things whenever possible
- Cache data and returns whenever possible
Expand Down