Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REGRESSION] Omnichannel visitor forward was applying wrong restrictions #17826

Merged
merged 3 commits into from
Jun 5, 2020
Merged

[REGRESSION] Omnichannel visitor forward was applying wrong restrictions #17826

merged 3 commits into from
Jun 5, 2020

Conversation

MarcosSpessatto
Copy link
Member

@MarcosSpessatto MarcosSpessatto commented Jun 4, 2020 •
edited
Loading

Proposed changes

Closes #17825

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@d-gubert d-gubert added this to the 3.3.1 milestone Jun 5, 2020
@renatobecker renatobecker merged commit 2abe15d into develop Jun 5, 2020
@renatobecker renatobecker deleted the fix-visitor-forward branch June 5, 2020 15:05
ggazzo added a commit that referenced this pull request Jun 8, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
f388313 
…/new-threads

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Administration User page blank opening users without email (#17836)
  [REGRESSION] Omnichannel visitor forward was applying wrong restrictions (#17826)
  [NEW] Assign oldest active user as owner when deleting last room owner (#16088)
@sampaiodiego sampaiodiego mentioned this pull request Jun 10, 2020
Merged
sampaiodiego pushed a commit that referenced this pull request Jun 10, 2020
@MarcosSpessatto @sampaiodiego
[REGRESSION] Omnichannel visitor forward was applying wrong restricti…
6b48d21 
…ons (#17826)

* return empty object if there is no callback

* Improve department forward restrictions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatobecker renatobecker renatobecker approved these changes

Assignees
No one assigned
Labels
type: regression
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.

Departments are not listed when transferring livechat calls to another department.
3 participants
@MarcosSpessatto @renatobecker @d-gubert