Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE][Performance] Solves problems regarding settings editing performance on Administration #17916

Merged
merged 29 commits into from
Jun 18, 2020
Merged

[IMPROVE][Performance] Solves problems regarding settings editing performance on Administration #17916

merged 29 commits into from
Jun 18, 2020

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jun 15, 2020 •
edited
Loading

Solves problems regarding settings editing performance on Administration.

Proposed changes

  • Lets SettingsContext handle public (privileged={false}) and private (privileged={true}) settings.
  • Adds EditableSettingsContext to handle state on settings administration pages.
  • Removes duplicated state.

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

tassoevan added 29 commits June 15, 2020 03:39
@tassoevan
Simplify settings comparison
0cb8baa
@tassoevan
Remove useReducer
c27e142
@tassoevan
Split privileged setting editing hooks
153b652
@tassoevan
Replace stateRef with maps for settings
6f3fc84
@tassoevan
Change PrivilegedSettingsProvider initialization
6007bf6
@tassoevan
Add useQuery hook
a4b130f
@tassoevan
Add small refactoring
65a8ae7
@tassoevan
Subscribe to edit privileged settings
7f0015e
@tassoevan
Subscribe to a setting or a section of a settings group
0372b6b
@tassoevan
Handle state only from collections
c2e507c
@tassoevan
Refine some types
ca683eb
@tassoevan
Fix some reactivity issues
95d3607
@tassoevan
Add eslint rules for React hooks
87428a0
@tassoevan
Move cached collections for settings
58769d6
@tassoevan
Prepare to unify all contexts for settings
d54f152
@tassoevan
Merge branch 'develop' into perf/privileged-settings
b9398ae
@tassoevan
Use custom queries to fetch settings
d5306a1
@tassoevan
Move hook to AdminSidebar
7686112
@tassoevan
Change setting update hooks
53ba377
@tassoevan
Augment Tracker.nonreactive
33cb20c
@tassoevan
Use a single SettingsProvider for public and private settings
6375114
@tassoevan
Rename PrivilegedSettingsContext as EditableSettingsContext
9dcb446
@tassoevan
Merge branch 'develop' into perf/privileged-settings
cf5b0e0
@tassoevan
Change setting editing actions
d55667b
@tassoevan
Change group actions on editing settings
d6b95a2
@tassoevan
Remove exceeding hooks from EditingSettingsContext
2a12dfe
@tassoevan
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into perf…
59a34d8 
…/privileged-settings
@tassoevan
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into perf…
398d9f5 
…/privileged-settings
@tassoevan
Fix some broken JSX
fb6ca09
@tassoevan tassoevan requested a review from a team June 18, 2020 03:59
@tassoevan tassoevan added this to the 3.4.0 milestone Jun 18, 2020
@tassoevan tassoevan changed the title perf/privileged-settings [IMPROVE] Performance when editing settings Jun 18, 2020
@tassoevan tassoevan marked this pull request as ready for review June 18, 2020 04:10
@ggazzo ggazzo changed the title [IMPROVE] Performance when editing settings [IMPROVE] Performance editing Admin settings Jun 18, 2020
@ggazzo ggazzo merged commit d73c7a7 into develop Jun 18, 2020
@ggazzo ggazzo deleted the perf/privileged-settings branch June 18, 2020 04:27
ggazzo added a commit that referenced this pull request Jun 18, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
0114c3a 
…apps_rewrite* 'develop' of github.com:RocketChat/Rocket.Chat: (28 commits) [IMPROVE] Performance editing Admin settings (#17916)  [IMPROVE] React hooks lint rules (#17941)  [FIX] StreamCast stream to server only streamers (#17942)  [FIX] Profile save button not activates properly when changing the username field (#16541)  [FIX] Outgoing webhook: Excessive spacing between trigger words (#17830)  [FIX] Links being escaped twice leading to visible encoded characters (#16481)  [NEW][API] New endpoints to manage User Custom Status `custom-user-status.create`, custom-user-status.delete` and `custom-user-status.update` (#16550)  [FIX] Message action popup doesn't adjust itself on screen resize (#16508)  [FIX] Not possible to translate the label of custom fields in user's Info (#15595)  [FIX] Close the user info context panel does not navigate back to the user's list (#14085)  [FIX] Missing pinned icon indicator for messages pinned (#16448)  Chatpal: limit results to current room (#17718)  Do not build Docker image for fork PRs (#17370)  [IMPROVE] Use REST for DDP calls by default (#17934)  [IMPROVE] Add rate limiter to UiKit endpoints (#17859)  LingoHub based on develop (#17796)  [IMPROVE] Change default upload settings to only block SVG files (#17933)  Update Dockerfile to not depend on custom base image (#17802)  [IMPROVE][Performance] Add new database indexes to improve data query performance (#17839)  [FIX] Undesirable message updates after user saving profile (#17930)  ...
gabriellsh added a commit that referenced this pull request Jun 18, 2020
@gabriellsh
Merge branch 'new/apps_rewrite' of github.com:RocketChat/Rocket.Chat …
cc80513 
…into new/apps_rewrite_local

* 'new/apps_rewrite' of github.com:RocketChat/Rocket.Chat: (30 commits)
  Sort imports
  Move sidebar items registration
  Embed useMenuOptions into AppMenu
  Fix route redirection
  Fix lint errors
  Fix infinite loop in CodeSettingInput
  Fix spacing in What Is It page
  [IMPROVE] Performance editing Admin settings (#17916)
  [IMPROVE] React hooks lint rules (#17941)
  [FIX] StreamCast stream to server only streamers (#17942)
  [FIX] Profile save button not activates properly when changing the username field (#16541)
  [FIX] Outgoing webhook: Excessive spacing between trigger words (#17830)
  [FIX] Links being escaped twice leading to visible encoded characters (#16481)
  [NEW][API] New endpoints to manage User Custom Status `custom-user-status.create`, custom-user-status.delete` and `custom-user-status.update` (#16550)
  [FIX] Message action popup doesn't adjust itself on screen resize (#16508)
  [FIX] Not possible to translate the label of custom fields in user's Info (#15595)
  [FIX] Close the user info context panel does not navigate back to the user's list (#14085)
  [FIX] Missing pinned icon indicator for messages pinned (#16448)
  Chatpal: limit results to current room (#17718)
  Do not build Docker image for fork PRs (#17370)
  ...
ggazzo added a commit that referenced this pull request Jun 18, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
1eb303a 
…/new-threads

* 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits)
  [FIX] Typo "coorosponding" (#17840)
  Regression: Infinite loop in CodeSettingInput (#17949)
  [NEW][ENTERPRISE] Download engagement data (#17920)
  [FIX] Hide system message add/remove owner  (#17938)
  [IMPROVE] Performance editing Admin settings (#17916)
  [IMPROVE] React hooks lint rules (#17941)
  [FIX] StreamCast stream to server only streamers (#17942)
  [FIX] Profile save button not activates properly when changing the username field (#16541)
  [FIX] Outgoing webhook: Excessive spacing between trigger words (#17830)
  [FIX] Links being escaped twice leading to visible encoded characters (#16481)
  [NEW][API] New endpoints to manage User Custom Status `custom-user-status.create`, custom-user-status.delete` and `custom-user-status.update` (#16550)
  [FIX] Message action popup doesn't adjust itself on screen resize (#16508)
  [FIX] Not possible to translate the label of custom fields in user's Info (#15595)
  [FIX] Close the user info context panel does not navigate back to the user's list (#14085)
  [FIX] Missing pinned icon indicator for messages pinned (#16448)
  Chatpal: limit results to current room (#17718)
  Do not build Docker image for fork PRs (#17370)
  [IMPROVE] Use REST for DDP calls by default (#17934)
  [IMPROVE] Add rate limiter to UiKit endpoints (#17859)
  LingoHub based on develop (#17796)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
@rodrigok rodrigok changed the title [IMPROVE] Performance editing Admin settings [IMPROVE][Performance] Solves problems regarding settings editing performance on Administration Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
subj: performance type: improvement ui/ux
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tassoevan @ggazzo