[FIX] Missing User when forwarding Omnichannel conversations via Apps-Engine #17918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 16, 2020
renatobecker
requested changes
Jun 19, 2020
app/apps/server/bridges/livechat.js
Outdated
| return Livechat.transfer( | ||
| this.orch.getConverters().get('rooms').convertAppRoom(currentRoom), | ||
| this.orch.getConverters().get('visitors').convertAppVisitor(visitor), | ||
| { userId: targetAgent.id, departmentId }, | ||
| { userId: targetAgent ? targetAgent.id : undefined, departmentId, transferredBy}, |
There was a problem hiding this comment.
Suggested change
| { userId: targetAgent ? targetAgent.id : undefined, departmentId, transferredBy}, | |
| { userId: targetAgent ? targetAgent.id : undefined, departmentId, transferredBy }, |
- add transferredBy property to transferData object in transferVisitor()
renatobecker
requested changes
Jun 19, 2020
| @@ -134,10 +134,18 @@ export class AppLivechatBridge { | |||
| currentRoom, | |||
| } = transferData; | |||
|
|
|||
| const appUser = Users.findOneByAppId(appId); | |||
| const transferredBy = { | |||
There was a problem hiding this comment.
Suggested change
| const transferredBy = { | |
| if (!appUser) { | |
| throw new Error('Invalid user, cannot transfer'); | |
| } | |
| const { _id, username, name, type } = appUser; | |
| const transferredBy = { | |
| _id, | |
| username, | |
| name, | |
| type, | |
| } |
There was a problem hiding this comment.
Incorporated this change in the latest commit. REF 997469f
Thanks for the review 😄
renatobecker
changed the title
renatobecker
approved these changes
Jun 19, 2020
renatobecker
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to close Issue #17911
Additionally, it adds a missing property
transferredByto thetransferDataobject begin passed on totransfermethod 👇Rocket.Chat/app/livechat/server/lib/Livechat.js
Line 580 in 77aff86
This is property is required for the following
checkinsaveTransferHistorymethod.Rocket.Chat/app/livechat/server/lib/Livechat.js
Line 556 in 77aff86
I'm assigning the
app-Userto this missing property since this method will always be triggered by an app.Issue(s)
Closes #17911
Screenshots
Handover Action is being processed properly
