Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW][ENTERPRISE] Omnichannel multiple business hours #17947

Merged
merged 63 commits into from
Jun 22, 2020
Merged

[NEW][ENTERPRISE] Omnichannel multiple business hours #17947

merged 63 commits into from
Jun 22, 2020

Conversation

MarcosSpessatto
Copy link
Member

@MarcosSpessatto MarcosSpessatto commented Jun 18, 2020 •
edited by rodrigok
Loading

Proposed changes

This PR adds the ability to add multiple Business Hours configurations. Each Business Hours configuration can be associated with multiple Departments.
In addition, both Single and Multiple configurations support different timezones.

Issue(s)

How to test or reproduce

Screenshots

New setting to define the behavior of the new Business Hours system:
Screen Shot 2020-07-03 at 12 53 29

Single Business Hours configuration:
Screen Shot 2020-07-03 at 12 52 11

List of existing Business Hours:
Screen Shot 2020-07-03 at 12 52 00

Multiple Business Hours configuration:
Screen Shot 2020-07-03 at 12 52 23

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

This implementation adds the ability to set up multiple Business Hours configurations. A new setting will define the behavior of the Business Hours system. There are two options available:

  • Single: This setting manages all Omnichannel agents. This option is suitable when there is only one team of agents.
  • Multiple: This setting allows managers to set up multiple Business Hours configurations. This option is suitable when then Teams of agents are grouped per department. Each department is allowed to have just one Business Hour configuration.

Another long-awaited feature launched by this implementation is the ability to define different timezones by Business hours.

Further comments

@MarcosSpessatto
Change omnichannel office hours data structure
f5c6d6d
@MarcosSpessatto
Rename omnichannel office hours templates
387e801
@MarcosSpessatto
Renaming things from office hour to business hour
6d4b2e6
@MarcosSpessatto
Partially remove LivechatOfficeHour model
a1adbbd
@MarcosSpessatto
remove obsolete setting
4803883
@MarcosSpessatto
Remove settings from the template
ebd93a9
@MarcosSpessatto
Add support to cron jobs on omnichannel business hours
5a911b3
@MarcosSpessatto
Merge branch 'develop' into improvements/refactor-livechat-office-hours
acf7b70
@MarcosSpessatto
Add dynamic template to omnichannel business hours
4f93201
@MarcosSpessatto
Merge branch 'develop' into improvements/refactor-livechat-office-hours
7d3e345
@MarcosSpessatto
Open and close business hours
d94d750
@MarcosSpessatto
Remove references to LivechatOfficeHours
d3e2670
@MarcosSpessatto
Merge branch 'develop' into improvements/refactor-livechat-office-hours
bb4c82b
@MarcosSpessatto
Open and close business hour automatically on startup and setting cha…
25c4d88 
…nges
@MarcosSpessatto
Merge branch 'develop' into improvements/refactor-livechat-office-hours
1becb7c
@MarcosSpessatto
Improve open and close business hours process
a2b2c9b
@MarcosSpessatto
Removing separated interfaces
c496ca2
@MarcosSpessatto
Merge branch 'develop' into improvements/refactor-livechat-office-hours
388afa0
@MarcosSpessatto
Merge branch 'develop' into improvements/refactor-livechat-office-hours
e0a0021
@MarcosSpessatto
Merge branch 'develop' into improvements/refactor-livechat-office-hours
0b05ad8
@MarcosSpessatto
Apply suggestions from review
9371c3d
@MarcosSpessatto
Merge branch 'develop' into improvements/refactor-livechat-office-hours
83e32f5
@MarcosSpessatto
Basic configuration to support multiple business hours
c890eb1
@renatobecker renatobecker added this to the 3.4.0 milestone Jun 21, 2020
@renatobecker renatobecker marked this pull request as ready for review June 21, 2020 14:25
@renatobecker renatobecker merged commit a89c90b into develop Jun 22, 2020
@renatobecker renatobecker deleted the feat/multiple-business-hours branch June 22, 2020 15:55
gabriellsh added a commit that referenced this pull request Jun 22, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
c3852b6 
…prune_discussions

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Remove useLazyRef hook usage (#18003)
  [FIX] User is prompted to reset their password when logging in with OAuth provider (#18001)
  [FIX] Missing i18n key for setting: Verify Email for External Accounts (#18002)
  Regression: Cannot save avatar change on admin (#17999)
  [NEW][ENTERPRISE] Omnichannel multiple business hours (#17947)
  [FIX] New Omnichannel Past Chats list padding (#17994)
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatobecker renatobecker renatobecker approved these changes

Assignees
No one assigned
Labels
feat: enterprise
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcosSpessatto @renatobecker