Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Room flickering if open a thread #18004

Merged
merged 6 commits into from
Jun 25, 2020
Merged

Regression: Room flickering if open a thread #18004

merged 6 commits into from
Jun 25, 2020

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jun 22, 2020

No description provided.

@ggazzo ggazzo added this to the 3.4.0 milestone Jun 22, 2020
sampaiodiego
sampaiodiego requested changes Jun 23, 2020
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working for some routes when coming (exiting) a room route, i.e.: directory and first time you go to a DM route (to create that conversation)

gabriellsh
gabriellsh previously approved these changes Jun 23, 2020
View reviewed changes
sampaiodiego
sampaiodiego requested changes Jun 23, 2020
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not working when trying to open some other pages while a channel is opened.

@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2020

This pull request introduces 1 alert when merging 51f48d4 into 14c6b9d - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@sampaiodiego sampaiodiego merged commit 69668d6 into develop Jun 25, 2020
@sampaiodiego sampaiodiego deleted the fix/blink branch June 25, 2020 03:44
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@gabriellsh gabriellsh gabriellsh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ggazzo @sampaiodiego @gabriellsh