Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Fix setting reply-to email header #18008

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Jun 22, 2020

Proposed changes

Fix the following error

W20200622-19:13:23.208(-3)? (STDERR) (node:52243) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
W20200622-19:22:19.636(-3)? (STDERR) === UnHandledPromiseRejection ===
W20200622-19:22:19.637(-3)? (STDERR) TypeError: Cannot set property 'Reply-To' of undefined
W20200622-19:22:19.637(-3)? (STDERR)     at getEmailData (app/lib/server/functions/notifications/email.js:163:3)
W20200622-19:22:19.638(-3)? (STDERR)     at app/lib/server/lib/sendNotificationsOnMessage.js:162:12
W20200622-19:22:19.638(-3)? (STDERR)     at Array.some (<anonymous>)
W20200622-19:22:19.638(-3)? (STDERR)     at app/lib/server/lib/sendNotificationsOnMessage.js:158:19
W20200622-19:22:19.638(-3)? (STDERR)     at /Users/diegosampaio/.meteor/packages/promise/.0.11.2.1xavwef.9sbp++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/meteor-promise/fiber_pool.js:43:40
W20200622-19:22:19.638(-3)? (STDERR) ---------------------------------
W20200622-19:22:19.638(-3)? (STDERR) Errors like this can cause oplog processing errors.
W20200622-19:22:19.641(-3)? (STDERR) Setting EXIT_UNHANDLEDPROMISEREJECTION will cause the process to exit allowing your service to automatically restart the process
W20200622-19:22:19.641(-3)? (STDERR) Future node.js versions will automatically exit the process
W20200622-19:22:19.642(-3)? (STDERR) =================================

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@sampaiodiego sampaiodiego added this to the 3.4.0 milestone Jun 22, 2020
@sampaiodiego sampaiodiego requested a review from ggazzo June 22, 2020 22:53
@sampaiodiego sampaiodiego merged commit 7e78049 into develop Jun 23, 2020
@sampaiodiego sampaiodiego deleted the fix-email-headers branch June 23, 2020 11:44
gabriellsh added a commit that referenced this pull request Jun 23, 2020
…geolocation_permission

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Deprecate check permission on integrations (#18024)
  Regression: Favorite and Featured fields not triggering changes (#18010)
  Regression: Fix setting reply-to email header (#18008)
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants