Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Few adjustments to accept fuselage theme #18009

Merged
merged 4 commits into from
Jul 17, 2020
Merged

[FIX] Few adjustments to accept fuselage theme #18009

merged 4 commits into from
Jul 17, 2020

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jun 23, 2020 •
edited
Loading

Proposed changes

DEMO using a special fuselage build:

Issue(s)

How to test or reproduce

Screenshots

image

image
image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@tassoevan
Copy link
Contributor

Related to #11071

@ggazzo ggazzo changed the title [WIP][FIX] Few adjustments to accept fuselage theme [FIX] Few adjustments to accept fuselage theme Jul 14, 2020
@ggazzo ggazzo added this to the 3.5.0 milestone Jul 14, 2020
@ggazzo ggazzo requested a review from gabriellsh July 14, 2020 04:26
@ggazzo ggazzo marked this pull request as ready for review July 17, 2020 17:10
@ggazzo ggazzo merged commit be55979 into develop Jul 17, 2020
@ggazzo ggazzo deleted the fix/theme branch July 17, 2020 17:40
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriellsh gabriellsh gabriellsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ggazzo @tassoevan @gabriellsh