Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Clipboard not working when permalinking a pinned message #18047

Merged
merged 2 commits into from
Jul 2, 2020

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jun 25, 2020

Closes #13130

Also did some small cleanups on the files

@MartinSchoeler MartinSchoeler requested a review from a team June 25, 2020 17:48
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ggazzo ggazzo merged commit 53effb3 into develop Jul 2, 2020
@ggazzo ggazzo deleted the clipboard-fix branch July 2, 2020 23:10
gabriellsh added a commit that referenced this pull request Jul 6, 2020
…into new/rewrite_account_profile

* 'rewrite/accounts' of github.com:RocketChat/Rocket.Chat:
  [FIX] Cannot open admin when server uses ROOT_URL with subpath (#18105) (#18147)
  [FIX] App details returns to apps table, instead of previous page (#18080)
  [FIX] Clipboard not working when permalinking a pinned message (#18047)
  [FIX] "Add reaction" icon missing when the viewport size is smaller than 500px (#18110)
  [FIX] Jitsi opening twice (#18111)
  [FIX] Email notifications were still being sent for online users (#18088)
  [FIX] The livechat agent activity monitor wasn't being initialised because due to an internal error (#18090)
gabriellsh added a commit that referenced this pull request Jul 6, 2020
…ocket.Chat into rewrite/user_preferences

* 'new/rewrite_account_profile' of github.com:RocketChat/Rocket.Chat:
  [FIX] Cannot open admin when server uses ROOT_URL with subpath (#18105) (#18147)
  [FIX] App details returns to apps table, instead of previous page (#18080)
  [FIX] Clipboard not working when permalinking a pinned message (#18047)
  [FIX] "Add reaction" icon missing when the viewport size is smaller than 500px (#18110)
  [FIX] Jitsi opening twice (#18111)
  [FIX] Email notifications were still being sent for online users (#18088)
  [FIX] The livechat agent activity monitor wasn't being initialised because due to an internal error (#18090)
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permalink to the pinned message is not copied to the clipboard
3 participants