Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Fix exit-room on livechat #18067

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Regression: Fix exit-room on livechat #18067

merged 2 commits into from
Jun 30, 2020

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jun 29, 2020 •
edited
Loading

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@ggazzo ggazzo added this to the 3.4.0 milestone Jun 29, 2020
@ggazzo ggazzo requested a review from a team June 29, 2020 20:18
@sampaiodiego
Fix race condition while exiting room route
4319550 
Thanks Gazzo, lord of the Tracker and guardian of codegueira
@ggazzo ggazzo requested a review from sampaiodiego June 29, 2020 23:02
@sampaiodiego sampaiodiego merged commit 2e6516d into develop Jun 30, 2020
@sampaiodiego sampaiodiego deleted the regression/fix-exit-room-livechat branch June 30, 2020 00:23
@sampaiodiego sampaiodiego mentioned this pull request Jun 30, 2020
Merged
dudizilla added a commit that referenced this pull request Jun 30, 2020
@dudizilla
Merge branch 'develop' of https://github.com/RocketChat/Rocket.Chat i…
adb97b7 
…nto fix/prune_discussions

* 'develop' of https://github.com/RocketChat/Rocket.Chat: (47 commits)
  [FIX] Corrects Typo in Analytics section of the admin page (#17984)
  Bump version to 3.5.0-develop
  Bump version to 3.4.0
  Bump version to 3.4.0-rc.5
  Regression: Fix update last message on delete (#18077)
  Bump version to 3.4.0-rc.4
  Regression: Wrong padding and colors on some tabs (#18068)
  Regression: Fix mentions on thread preview (#18071)
  Upgrade Livechat Widget version to 1.6.0 (#18070)
  Regression: Fix exit-room on livechat (#18067)
  Regresion: Issue with reply button on broadcast channel
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ggazzo @sampaiodiego