[FIX] File uploads for unknown file types but nothing is blocked

[20051231]

Proposed changes

I When the block list is empty, all file types should be allowed. But if the browser does not recognize the mime of a file type, the file is still rejected.

Issue(s)

#16836

How to test or reproduce

Screenshots

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Hotfix (a major bugfix that has to be merged asap)
• Documentation Update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

[sampaiodiego]

Thanks for the fix @20051231 🤗

[stleitner]

This only works if the block list is empty. If another media type is blocked, files with unrecognized mime type still fail.

[scratttt]

This only works if the block list is empty. If another media type is blocked, files with unrecognized mime type still fail.

Hello, Do you think this can be solved? If another media type is blocked, files with unrecognized mime type still fail.

Thanks!!

[20051231]

This only works if the block list is empty. If another media type is blocked, files with unrecognized mime type still fail.

Hello, Do you think this can be solved? If another media type is blocked, files with unrecognized mime type still fail.

Thanks!!

If a blocked mime is not recognized by the browser, the file still need to be blocked so I did not change the logic in this case.

I think we might lookup the mime from the file extension in case of unrecognized mime. Or accept both mime and extension in the list?

[scratttt]

It is an option, if the browser does not recognize the mime, search if the file extension is in the whitelist.

[sprietNathanael]

It seems files without mime-types still can not be uploaded. Is there a way to make it work?

[jcarlosroldan]

We are also having this problem. The issue is not solved, shouldn't it be open instead of merged?

[kmare]

I believe it should be open as I have the same issue still.

[sampaiodiego]

just to make sure, do you guys have both blacklist and whitelist settings blank and can still not upload files? if so, please open a new issue