Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Notification with id-only isn't showed by iOS devices #18353

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Regression: Notification with id-only isn't showed by iOS devices #18353

merged 2 commits into from
Jul 23, 2020

Conversation

djorkaeffalexandre
Copy link
Contributor

@djorkaeffalexandre djorkaeffalexandre commented Jul 23, 2020

Proposed changes

Add a space on the text property of the notification just to this be right handled by iOS devices.

Issue(s)

How to test or reproduce

It's an under development feature on our mobile clients so only can be tested by users that have our internal beta test on TestFlight using the unstable server.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

We're doing something similar here to handle the case where the roomName and message was hidden by admin on notification privacy settings.

Further comments

@sampaiodiego sampaiodiego changed the title [FIX] Notification with id-only isn't showed by iOS devices Regression: Notification with id-only isn't showed by iOS devices Jul 23, 2020
@sampaiodiego sampaiodiego merged commit 4278642 into RocketChat:develop Jul 23, 2020
@sampaiodiego sampaiodiego mentioned this pull request Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants