[FIX] Push gateway and cloud integration

[sampaiodiego]

Proposed changes

Add more strict relationship between push gateway and cloud registration.

Disable push gateway if server is not registered to our cloud services but also alerts admins via a banner and a message as shown on the screenshot below.

Issue(s)

How to test or reproduce

Screenshots

• alert and message sent to admins during upgrade
  

• new description to settings
  

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Hotfix (a major bugfix that has to be merged asap)
• Documentation Update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

[geekgonecrazy]

This alert is only when disabled indirectly right?

[sampaiodiego]

the alert is triggered only during server upgrade if push gateway is enabled and server is not registered and cloud services terms not agreed. so in this scenario the push gateway setting will be automatically disabled and the alert will be sent.

after server upgrade push gateway will be blocked if those conditions are not met, thus no alert needed.

[geekgonecrazy]

I think we need to make sure to add a checkbox on the connectivity services screen to agree otherwise once through wizard they have no clear place to find this

[sampaiodiego]

I think we need to make sure to add a checkbox on the connectivity services screen to agree otherwise once through wizard they have no clear place to find this

we'll add a checkbox in another PR 😉

we'll add a checkbox in another PR

[Exordian]

This change will also disable non-official push gateways (when configured). I guess that's not intended, since this should not require any terms and conditions from the rocketchat cloud infrastructure.

[rodrigok]

@Exordian that's a good question, we didn't realize other push gateways may exist. Will figure out a solution for that.