-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Omnichannel session monitor is not starting #18412
Merged
sampaiodiego
merged 3 commits into
develop
from
omnichannel/fix-auto-closing-omnichannel-session
Jul 31, 2020
Merged
[FIX] Omnichannel session monitor is not starting #18412
sampaiodiego
merged 3 commits into
develop
from
omnichannel/fix-auto-closing-omnichannel-session
Jul 31, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatobecker
changed the title
[FIX] Omnichannel session monitor not being initiated
[FIX] Omnichannel session monitor is not starting
Jul 28, 2020
sampaiodiego
requested changes
Jul 31, 2020
sampaiodiego
approved these changes
Jul 31, 2020
sampaiodiego
deleted the
omnichannel/fix-auto-closing-omnichannel-session
branch
July 31, 2020 22:42
sampaiodiego
pushed a commit
that referenced
this pull request
Jul 31, 2020
* Fix Omnicahnnel session handler. * Fix remove user process.
Merged
sampaiodiego
pushed a commit
that referenced
this pull request
Aug 1, 2020
* Fix Omnicahnnel session handler. * Fix remove user process.
gabriellsh
added a commit
that referenced
this pull request
Aug 10, 2020
…omni * 'develop' of github.com:RocketChat/Rocket.Chat: [NEW] Add REST API endpoint to search Livechat visitors (#18514) LingoHub based on develop (#18516) Update README.md (#18503) [NEW] Channel avatar (#18443) [FIX] Sending notifications from senders without a name (#18479) [FIX] UserCard avatar cache (avatarETag) (#18466) [IMPROVE] Admin Info page requires permission (#18408) [FIX] Marking room as read with unread threads still (#18410) [FIX] Random generated password not matching the Password Policy (#18475) Typo in privacy agreement message (#18476) bugfix for uploading files from livechat (#18474) LingoHub based on develop (#18465) [NEW] Add the ability to set the character message limit on Livechat widget (#18261) [FIX] Migration 194 (#18457) [FIX] Omnichannel session monitor is not starting (#18412) [FIX] Invalid MIME type when uploading audio files (#18426) [FIX] Error when updating omnichannel department without agents parameter (#18428) [FIX] Omnichannel Take Inquiry endpoint checking wrong permission (#18446) [FIX] Multiple push notifications sent via native drivers (#18442) [FIX] Appending 'false' to Jitsi URL (#18430)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The Omnichannel session monitor wasn't being initiated due to bad implementation, there was a wrong type cast statement which was causing the issue.
Issue(s)
CLOSES #18259
How to test or reproduce
Sessions
sectionClose
orForward
toHow to Handle Open Sessions When Agent Goes Offline
settingHow Long to Wait After Agent Goes Offline
settingoffline
How to Handle Open Sessions When Agent Goes Offline
after theHow Long to Wait After Agent Goes Offline
is reachedScreenshots
Types of changes
Checklist
Changelog
Further comments