Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Push Notifications retry from max 31 hours to max 31 minutes #18558

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Reduce Push Notifications retry from max 31 hours to max 31 minutes #18558

merged 1 commit into from
Aug 14, 2020

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Aug 14, 2020 •
edited
Loading

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Changelog

Previews logic was retring in 0.1s, 1s, 11s, 2m, 18m, 3h and 31h, now it’s retrying in 1m, 3m, 7m, 15m and 31m

Further comments

@rodrigok
Reduce Push Notifications retry from max 31 hours to max 31 minutes
558fcdb 
Previews logic was retring in 0.1s, 1s, 11.1s, 2m, 18m, 3h and 31h, now it’s retrying in 1m, 3m, 7m, 15m and 31m
@rodrigok rodrigok added this to the 3.6.0 milestone Aug 14, 2020
@rodrigok rodrigok requested a review from sampaiodiego August 14, 2020 12:29
@sampaiodiego sampaiodiego merged commit 43ba951 into develop Aug 14, 2020
@sampaiodiego sampaiodiego deleted the push-retry branch August 14, 2020 13:22
@sampaiodiego sampaiodiego mentioned this pull request Aug 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rodrigok @sampaiodiego