Do not retry and log warning when push notification was not authorised

[rodrigok]

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Hotfix (a major bugfix that has to be merged asap)
• Documentation Update (if none of the other choices apply)

Changelog

Further comments

[sampaiodiego]

I guess this is one of the bad habits that optional chaining introduces, with this change the code is now checking twice if response is defined.. IMO we should avoid this and in this case we could use a single if to check if response.statusCode exists:

			if (response?.statusCode) {
				if (response.statusCode === 406) {
					logger.info('removing push token', token);
					appTokensCollection.remove({
						$or: [{
							'token.apn': token,
						}, {
							'token.gcm': token,
						}],
					});
					return;
				}

				if (response.statusCode === 401) {
					logger.warn('Error sending push to gateway (not authorized)', response);
					return;
				}
			}
...

[ggazzo]

I agree, sometimes this feature leads us not to question if some structures are correct, for example here, why would the respose be empty ?, maybe the error of this being tested first ... I saw it a lot on the coffescript code and I dont like it... try to write using ifs or ternaries before, and maybe these questions would appear 🤔