Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Revert silent: true #18671

Merged
merged 1 commit into from
Aug 25, 2020
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Aug 25, 2020

closes #18441

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@ggazzo ggazzo requested review from sampaiodiego and a team August 25, 2020 15:02
@ggazzo ggazzo added this to the 3.6.0 milestone Aug 25, 2020
@sampaiodiego sampaiodiego merged commit 00c243e into develop Aug 25, 2020
@sampaiodiego sampaiodiego deleted the regression/notification-sounds branch August 25, 2020 19:52
@sampaiodiego sampaiodiego mentioned this pull request Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sound settings are ignored since 3.5.0
2 participants