Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Bundle the package hepburn #18715

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Regression: Bundle the package hepburn #18715

merged 1 commit into from
Aug 28, 2020

Conversation

tassoevan
Copy link
Contributor

Proposed changes

The web client breaks on Internet Explorer 11 🤮 because, after updating limax, a package called hepburn was included adding some arrow functions to the final bundle.

Issue(s)

How to test or reproduce

See the web client on Internet Explorer 11 🤢

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@tassoevan tassoevan added this to the 4.0.0 milestone Aug 28, 2020
@tassoevan tassoevan requested review from rodrigok, sampaiodiego and a team August 28, 2020 19:18
@ggazzo ggazzo changed the title [FIX] Bundle the package hepburn Regression: Bundle the package hepburn Aug 28, 2020
@ggazzo ggazzo modified the milestones: 4.0.0, 3.6.0 Aug 28, 2020
@ggazzo ggazzo merged commit a68a8b7 into develop Aug 28, 2020
@ggazzo ggazzo deleted the fix/ie11 branch August 28, 2020 20:42
@sampaiodiego sampaiodiego mentioned this pull request Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants