fix: Expedite scheduled push notifications when user switches from online to away/offline #19104
+36
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Expedite scheduled push notifications when user switches from online to away/offline
Issue(s)
Fixes #19097
How to test or reproduce
statusConnection
is stillonline
(this is another issue probably for Rocket.Chat.ReactNative how this sometimes can happen, but it does happen and quite easy to reproduce by just using the phone's task killer)offline
. But this works: open Rocket.Chat for Android, turn on airplane mode, kill the app, turn off airplane mode, now Rocket.Chat server user'sstatusConnection
is stillonline
.statusConnection
isonline
according to server, meaning push is scheduled in 120 secondsstatusConnection
is now eitheroffline
oraway
.New behavior:
schedule
tonow = new Date()
, meaning push will be sent soon by workerScreenshots
Types of changes
Checklist
Changelog
Expedite scheduled push notifications when user switches from online to away/offline
Further comments
Improves upon #17357, #17907, RocketChat/Rocket.Chat.ReactNative#2507, and #19061