-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] Rewrite Room Files as React Component #19580
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t into feat/rewrite-files
…t into feat/rewrite-files
…t into feat/rewrite-files
This pull request fixes 1 alert when merging e574470 into 8a0258f - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging b40aad3 into 8a0258f - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging b459c2a into 8a0258f - view on LGTM.com fixed alerts:
|
ggazzo
approved these changes
Dec 16, 2020
dougfabris
changed the title
[IMPROVE] Rewrite Room Files
[IMPROVE] Rewrite Room Files as React Component
Dec 16, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue(s)
How to test or reproduce
Screenshots
Types of changes
Checklist
Changelog
Further comments