Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Rewrite Room Files as React Component #19580

Merged
merged 24 commits into from
Dec 16, 2020
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Nov 18, 2020

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@ggazzo ggazzo marked this pull request as ready for review December 16, 2020 02:31
@RocketChat RocketChat deleted a comment from lgtm-com bot Dec 16, 2020
@lgtm-com
Copy link

lgtm-com bot commented Dec 16, 2020

This pull request fixes 1 alert when merging e574470 into 8a0258f - view on LGTM.com

fixed alerts:

  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link

lgtm-com bot commented Dec 16, 2020

This pull request fixes 1 alert when merging b40aad3 into 8a0258f - view on LGTM.com

fixed alerts:

  • 1 for Incomplete string escaping or encoding

@lgtm-com
Copy link

lgtm-com bot commented Dec 16, 2020

This pull request fixes 1 alert when merging b459c2a into 8a0258f - view on LGTM.com

fixed alerts:

  • 1 for Incomplete string escaping or encoding

@ggazzo ggazzo merged commit a2c0dab into develop Dec 16, 2020
@ggazzo ggazzo deleted the feat/rewrite-files branch December 16, 2020 06:23
@dougfabris dougfabris changed the title [IMPROVE] Rewrite Room Files [IMPROVE] Rewrite Room Files as React Component Dec 16, 2020
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants