Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove extra parentheses from return type #19598

Merged

Conversation

ArnoSaine
Copy link
Contributor

Proposed changes

Removing the extra parentheses allows this component to be compiled using Babel.

Issue(s)

-

How to test or reproduce

Test using Babel JS Repl:

  1. Open Babel JS Repl
  2. Check "PRESETS: typescript"
  3. Paste file source to the input field

It's expected the code to be compiled, but it errors /repl.tsx: Unexpected token, expected ";" (7:68).

Screenshots

-

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

-

Further comments

-

@sampaiodiego sampaiodiego changed the title [FIX] Remove extra parentheses from return type Chore: Remove extra parentheses from return type Dec 11, 2020
@sampaiodiego sampaiodiego merged commit 3f70206 into RocketChat:develop Dec 11, 2020
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants