Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Unable to reset password by Email if upper case character is pr… #19643

Merged

Conversation

bhavayAnand9
Copy link
Contributor

@bhavayAnand9 bhavayAnand9 commented Nov 21, 2020

Proposed changes

sendResetPasswordEmail is a case sensitive function, so email should be lowercased before passing it as arg to sendResetPasswordEmail fn

Issue(s)

Closes #19622

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

fix an issue where email in forgot password form if uppercased throws error

Further comments

@bhavayAnand9
Copy link
Contributor Author

Hi! @ggazzo Could you please review this PR? Thanks

@ggazzo ggazzo added this to the 3.11.0 milestone Jan 12, 2021
@ggazzo ggazzo merged commit 843ef85 into RocketChat:develop Jan 12, 2021
gabriellsh added a commit that referenced this pull request Jan 14, 2021
…rewrite-announcement

* 'develop' of github.com:RocketChat/Rocket.Chat: (23 commits)
  Regression: Info Page Icon style and usage graph breaking (#20180)
  Chore: Change console.warning() to console.warn() (#20200)
  [FIX] Room's list showing all rooms with same name (#20176)
  Regression: Change sort icon (#20177)
  [FIX] Wrong userId when open own user profile (#20181)
  [FIX] Livechat.RegisterGuest method removing unset fields (#20124)
  [IMPROVE] Rewrite Prune Messages as React component (#19900)
  [FIX] Change header's favorite icon to filled star (#20174)
  [FIX] Initial values update on Account Preferences  (#19938)
  [FIX] Unable to reset password by Email if upper case character is present (#19643)
  [FIX] Video call message not translated (#18722)
  [NEW] Server Info page (#19517)
  [IMPROVE] Title for user avatar buttons (#20083)
  [FIX] Admin User Info email verified status (#20110)
  [IMPROVE] Tooltip added for Kebab menu on chat header (#20116)
  [FIX] Translate keyword for 'Showing results of' in tables (#20134)
  [FIX] Markdown added for Header Room topic (#20021)
  [FIX] Status circle in profile section (#20016)
  [FIX] Normalize messages for users in endpoint chat.getStarredMessages (#19962)
  [FIX] minWidth in FileIcon to prevent layout to broke (#19942)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 1, 2021
@zhouzscander
Copy link

@bhavayAnand9 Not sure if this was reverted or there's a regression but this issue is back in 3.14.4, not sure how far back it goes.

@bhavayAnand9
Copy link
Contributor Author

Hi! @zhouzscander, Thanks for reporting
I'll check this & sorry for the delay in response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to reset password by Email if email contains upper case letter
3 participants