Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update escape-related helpers #19655

Merged
merged 7 commits into from
Nov 25, 2020
Merged

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Nov 23, 2020

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@lgtm-com
Copy link

lgtm-com bot commented Nov 23, 2020

This pull request introduces 2 alerts when merging 9637bef into 5269866 - view on LGTM.com

new alerts:

  • 2 for Superfluous trailing arguments

@tassoevan tassoevan changed the title perf/escape-html Update escape-related helpers Nov 23, 2020
@tassoevan tassoevan requested a review from a team November 23, 2020 22:55
@tassoevan tassoevan marked this pull request as ready for review November 23, 2020 22:55
@ggazzo ggazzo added this to the 3.10.0 milestone Nov 24, 2020
@tassoevan tassoevan merged commit 56ece62 into feat/message-parsing Nov 25, 2020
@tassoevan tassoevan deleted the perf/escape-html branch November 25, 2020 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants