Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render message location in component #19819

Merged
merged 2 commits into from
Dec 10, 2020

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Dec 10, 2020

Proposed changes

From our efforts to move towards React and fixing long-standing issues in message rendering, this PR (1) removes mapview as a renderMessage callback and (2) adds a component in message template to render attached location information.

Issue(s)

How to test or reproduce

Share your location.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@tassoevan tassoevan changed the title [IMPROVE] Render message location in component Render message location in component Dec 10, 2020
@tassoevan tassoevan requested a review from a team December 10, 2020 03:29
@tassoevan tassoevan added this to the 3.10.0 milestone Dec 10, 2020
@tassoevan tassoevan marked this pull request as ready for review December 10, 2020 03:30
@tassoevan tassoevan merged commit 8062e06 into feat/message-parsing Dec 10, 2020
@tassoevan tassoevan deleted the feat/message-location branch December 10, 2020 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants