Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Admin Users screen sorting showing deactivated users in wrong order #19898

Merged
merged 2 commits into from
Dec 22, 2020
Merged

[FIX] Admin Users screen sorting showing deactivated users in wrong order #19898

merged 2 commits into from
Dec 22, 2020

Conversation

alansikora
Copy link
Contributor

Description:

Sorting Issue on USERS page

Steps to reproduce:

  1. Go to admin
  2. Click on USERS
  3. Click on STATUS (or any column)

Expected behavior:

Items are sorted correctly.

Actual behavior:

Server Setup Information:

  • Version of Rocket.Chat Server: 3.8.0
  • Operating System: Ubuntu 20.04.1
  • Deployment Method: Manual;
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version: 12.18.4
  • MongoDB Version: 4.0.21

Client Setup Information

  • Desktop App or Browser Version: Browser (Chrome Edge)
  • Operating System: Windows 10

@sampaiodiego sampaiodiego changed the title Fixed the user sorting error and added the option to send more than one sort property [FIX] Admin > Users sorting showing deactivated users in wrong order Dec 22, 2020
@sampaiodiego sampaiodiego changed the title [FIX] Admin > Users sorting showing deactivated users in wrong order [FIX] Admin Users screen sorting showing deactivated users in wrong order Dec 22, 2020
@sampaiodiego sampaiodiego merged commit 39e3385 into develop Dec 22, 2020
@sampaiodiego sampaiodiego deleted the fix/users-sorting branch December 22, 2020 02:20
@teak421 teak421 mentioned this pull request Dec 22, 2020
Closed
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@ggazzo ggazzo Awaiting requested review from ggazzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alansikora @sampaiodiego